Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor game map display to use a common component #579

Open
sei-bstein opened this issue Jan 6, 2025 · 0 comments
Open

Refactor game map display to use a common component #579

sei-bstein opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sei-bstein
Copy link
Contributor

Currently, the game map displayed in the competitive player view does not use a component - it's just raw SVG using the game data. When we created Game Center, we created a new component that renders the map (and also handles updating the image, clearing it, etc.) Because of this difference, we had a little inconsistency between how the image path is resolved. The component uses a pipe to handle the fallback to the default map image, while the competitive play view relies on a transformation that happens in game.service.

It's my perspective that the transformation inside the service is not ideal, because it slightly misrepresents what's coming out of the API. But I'm biased, because it's my component and pipe 🤣 . Ideal solution is to update competitive view to use the new component.

@sei-bstein sei-bstein added the bug Something isn't working label Jan 6, 2025
@sei-bstein sei-bstein self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant