You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the game map displayed in the competitive player view does not use a component - it's just raw SVG using the game data. When we created Game Center, we created a new component that renders the map (and also handles updating the image, clearing it, etc.) Because of this difference, we had a little inconsistency between how the image path is resolved. The component uses a pipe to handle the fallback to the default map image, while the competitive play view relies on a transformation that happens in game.service.
It's my perspective that the transformation inside the service is not ideal, because it slightly misrepresents what's coming out of the API. But I'm biased, because it's my component and pipe 🤣 . Ideal solution is to update competitive view to use the new component.
The text was updated successfully, but these errors were encountered:
Currently, the game map displayed in the competitive player view does not use a component - it's just raw SVG using the game data. When we created Game Center, we created a new component that renders the map (and also handles updating the image, clearing it, etc.) Because of this difference, we had a little inconsistency between how the image path is resolved. The component uses a pipe to handle the fallback to the default map image, while the competitive play view relies on a transformation that happens in
game.service
.It's my perspective that the transformation inside the service is not ideal, because it slightly misrepresents what's coming out of the API. But I'm biased, because it's my component and pipe 🤣 . Ideal solution is to update competitive view to use the new component.
The text was updated successfully, but these errors were encountered: