Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search requests by dataset #36

Open
franzoni opened this issue Dec 10, 2015 · 1 comment
Open

search requests by dataset #36

franzoni opened this issue Dec 10, 2015 · 1 comment

Comments

@franzoni
Copy link

emerged on discussion
2015/12/10
https://twiki.cern.ch/twiki/bin/view/CMS/PreMCCM

users would like to be able to:

  • search for request in pmp by querying the dataset name
  • possibly with wildcard saerch

Needs dataset name be added to the elastic indexing

@jacobwalkr
Copy link
Contributor

This is a hard one. Dataset names contain both slashes and dashes, both of which act as special characters at various places in the pMp pipeline. Commit 805743b moves query parameters into the URL's parameter string to avoid the issue of extra slashes within the path, and e269668 extends the suggestions API to allow some completion of dataset names, but this falls flat as soon as you type a slash or a dash.

Additionally, searching ElasticSearch by output dataset with a simple URL query returns really ambiguous results and so warrants a full query as JSON in the request body. However, dashes need to be escaped in ElasticSearch and \- is an invalid character escape sequence in JSON, causing it to throw an error before even getting to the search. A potential solution is to re-index requests in ElasticSearch so that the output_dataset field is not_analyzed - this should stop the ElasticSearch parser from processing the dashes in dataset names when requests are indexed.

I don't have nearly enough time left now to explore these options, so hopefully this will be useful to whoever takes this up next :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants