Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my package qrcode is based off the same core libraray. can we work together instead of fragmenting the solutions? #1

Open
soldair opened this issue Jul 16, 2012 · 8 comments

Comments

@soldair
Copy link

soldair commented Jul 16, 2012

?? =)

@soldair
Copy link
Author

soldair commented Jul 16, 2012

@cmanzana
Copy link
Owner

Hi Ryan,

certainly!
the only thing I need is to have the Img and Table support, which I guess
should be fairly straightforward in your module (I guess it is about
'undeleting' code)

regards,
--Carlos--

On Mon, Jul 16, 2012 at 3:58 PM, Ryan Day <
[email protected]

wrote:

?? =)


Reply to this email directly or view it on GitHub:
#1

@soldair
Copy link
Author

soldair commented Jul 16, 2012

it provides images from node-canvas.
i've been working on replacing this compiled dependency with an all
javascript png library ive been adapting.

in my exposed interface i have drawBitArray which is the only thing needed
to support any other output format.
i even have a terminal renderer for viewing codes in your shell =). kinda
silly but fun.

ill think about it a bit more.
i really didn't need the table format because my package works on the
client side in ie with excanvas. did you come to a similar conclusion?

R

On Mon, Jul 16, 2012 at 9:03 AM, Carlos Manzanares <
[email protected]

wrote:

Hi Ryan,

certainly!
the only thing I need is to have the Img and Table support, which I guess
should be fairly straightforward in your module (I guess it is about
'undeleting' code)

regards,
--Carlos--

On Mon, Jul 16, 2012 at 3:58 PM, Ryan Day <
[email protected]

wrote:

?? =)


Reply to this email directly or view it on GitHub:
#1


Reply to this email directly or view it on GitHub:
#1 (comment)

@cmanzana
Copy link
Owner

my use case is so that I would like to display the QR code from all kind
of mobile phones (including featured phones)

initially I tried doing the computation from the client side directly
(using directly the qrcode.js), but this was too intensive for old symbian
phones (my old Nokia E75 was unresponsive for few minutes when trying to
generate the QR code)
this was the reason why I decided to move the processing to the server side
(node.js) and generate the QR code on the fly and just feed the

or

tag back to the mobile phone
The reason why I don't want to use canvas is that it is only supported by
smartphones
Also I want to generate the QR code on the fly and not store any
intermediate files in the server side (i.e.: I don't want to generate a
.png file in the server side and then link that to the page served to the
mobile phone)

I have not checked your code base yet, I will take a look during tomorrow
and see if I can easily add it there myself without generating code smells
in your project

On Mon, Jul 16, 2012 at 7:12 PM, Ryan Day <
[email protected]

wrote:

it provides images from node-canvas.
i've been working on replacing this compiled dependency with an all
javascript png library ive been adapting.

in my exposed interface i have drawBitArray which is the only thing needed
to support any other output format.
i even have a terminal renderer for viewing codes in your shell =). kinda
silly but fun.

ill think about it a bit more.
i really didn't need the table format because my package works on the
client side in ie with excanvas. did you come to a similar conclusion?

R

On Mon, Jul 16, 2012 at 9:03 AM, Carlos Manzanares <
[email protected]

wrote:

Hi Ryan,

certainly!
the only thing I need is to have the Img and Table support, which I guess
should be fairly straightforward in your module (I guess it is about
'undeleting' code)

regards,
--Carlos--

On Mon, Jul 16, 2012 at 3:58 PM, Ryan Day <
[email protected]

wrote:

?? =)


Reply to this email directly or view it on GitHub:
#1


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)

@soldair
Copy link
Author

soldair commented Jul 16, 2012

i mean my code uses canvas on the server side to output images and data
uris for that.
anyway ill do some thinking on how to ratify our differences after work =)

its awesome to see you so involved. i love making modules!

R

On Mon, Jul 16, 2012 at 9:34 AM, Carlos Manzanares <
[email protected]

wrote:

my use case is so that I would like to display the QR code from all kind
of mobile phones (including featured phones)

initially I tried doing the computation from the client side directly
(using directly the qrcode.js), but this was too intensive for old symbian
phones (my old Nokia E75 was unresponsive for few minutes when trying to
generate the QR code)
this was the reason why I decided to move the processing to the server side
(node.js) and generate the QR code on the fly and just feed the

or
tag back to the mobile phone
The reason why I don't want to use canvas is that it is only supported by
smartphones
Also I want to generate the QR code on the fly and not store any
intermediate files in the server side (i.e.: I don't want to generate a
.png file in the server side and then link that to the page served to the
mobile phone)

I have not checked your code base yet, I will take a look during tomorrow
and see if I can easily add it there myself without generating code smells
in your project

On Mon, Jul 16, 2012 at 7:12 PM, Ryan Day <
[email protected]

wrote:

it provides images from node-canvas.
i've been working on replacing this compiled dependency with an all
javascript png library ive been adapting.

in my exposed interface i have drawBitArray which is the only thing
needed
to support any other output format.
i even have a terminal renderer for viewing codes in your shell =). kinda
silly but fun.

ill think about it a bit more.
i really didn't need the table format because my package works on the
client side in ie with excanvas. did you come to a similar conclusion?

R

On Mon, Jul 16, 2012 at 9:03 AM, Carlos Manzanares <
[email protected]

wrote:

Hi Ryan,

certainly!
the only thing I need is to have the Img and Table support, which I
guess
should be fairly straightforward in your module (I guess it is about
'undeleting' code)

regards,
--Carlos--

On Mon, Jul 16, 2012 at 3:58 PM, Ryan Day <
[email protected]

wrote:

?? =)


Reply to this email directly or view it on GitHub:
#1


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)

@cmanzana
Copy link
Owner

Hi Ryan,

I have taken a look to your module, and unfortunately your dependency to
canvas creates quite some issues for my project
I am hosting my project in heroku and the options to get canvas to run
there are not very appealing (see:
https://github.com/LearnBoost/node-canvas/wiki/Installation-Heroku)
unfortunately I do not see other way to solve this issue than to have two
different modules:

  • one that depends on canvas (your module)
  • one that does not depend on canvas (my module)

I know this is far from optimal, so let me know if you have some other
suggestions

--Carlos--

On Mon, Jul 16, 2012 at 8:50 PM, Ryan Day <
[email protected]

wrote:

i mean my code uses canvas on the server side to output images and data
uris for that.
anyway ill do some thinking on how to ratify our differences after work =)

its awesome to see you so involved. i love making modules!

R

On Mon, Jul 16, 2012 at 9:34 AM, Carlos Manzanares <
[email protected]

wrote:

my use case is so that I would like to display the QR code from all
kind
of mobile phones (including featured phones)

initially I tried doing the computation from the client side directly
(using directly the qrcode.js), but this was too intensive for old
symbian
phones (my old Nokia E75 was unresponsive for few minutes when trying to
generate the QR code)
this was the reason why I decided to move the processing to the server
side
(node.js) and generate the QR code on the fly and just feed the


or
tag back to the mobile phone
The reason why I don't want to use canvas is that it is only supported by
smartphones
Also I want to generate the QR code on the fly and not store any
intermediate files in the server side (i.e.: I don't want to generate a
.png file in the server side and then link that to the page served to the
mobile phone)

I have not checked your code base yet, I will take a look during tomorrow
and see if I can easily add it there myself without generating code
smells
in your project

On Mon, Jul 16, 2012 at 7:12 PM, Ryan Day <
[email protected]

wrote:

it provides images from node-canvas.
i've been working on replacing this compiled dependency with an all
javascript png library ive been adapting.

in my exposed interface i have drawBitArray which is the only thing
needed
to support any other output format.
i even have a terminal renderer for viewing codes in your shell =).
kinda
silly but fun.

ill think about it a bit more.
i really didn't need the table format because my package works on the
client side in ie with excanvas. did you come to a similar conclusion?

R

On Mon, Jul 16, 2012 at 9:03 AM, Carlos Manzanares <
[email protected]

wrote:

Hi Ryan,

certainly!
the only thing I need is to have the Img and Table support, which I
guess
should be fairly straightforward in your module (I guess it is about
'undeleting' code)

regards,
--Carlos--

On Mon, Jul 16, 2012 at 3:58 PM, Ryan Day <
[email protected]

wrote:

?? =)


Reply to this email directly or view it on GitHub:
#1


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)

@soldair
Copy link
Author

soldair commented Jul 19, 2012

im removing the dependency on node canvas for an all js png implementation.
probably by the end of the week.
acceptable?

canvas was such a small part so as long as i can generate png data and
base64 encode it i can get it going.

R
On Thu, Jul 19, 2012 at 6:59 AM, Carlos Manzanares <
[email protected]

wrote:

Hi Ryan,

I have taken a look to your module, and unfortunately your dependency to
canvas creates quite some issues for my project
I am hosting my project in heroku and the options to get canvas to run
there are not very appealing (see:
https://github.com/LearnBoost/node-canvas/wiki/Installation-Heroku)
unfortunately I do not see other way to solve this issue than to have two
different modules:

  • one that depends on canvas (your module)
  • one that does not depend on canvas (my module)

I know this is far from optimal, so let me know if you have some other
suggestions

--Carlos--

On Mon, Jul 16, 2012 at 8:50 PM, Ryan Day <
[email protected]

wrote:

i mean my code uses canvas on the server side to output images and data
uris for that.
anyway ill do some thinking on how to ratify our differences after work
=)

its awesome to see you so involved. i love making modules!

R

On Mon, Jul 16, 2012 at 9:34 AM, Carlos Manzanares <
[email protected]

wrote:

my use case is so that I would like to display the QR code from all
kind
of mobile phones (including featured phones)

initially I tried doing the computation from the client side directly
(using directly the qrcode.js), but this was too intensive for old
symbian
phones (my old Nokia E75 was unresponsive for few minutes when trying
to
generate the QR code)
this was the reason why I decided to move the processing to the server
side
(node.js) and generate the QR code on the fly and just feed the


or
tag back to the mobile phone
The reason why I don't want to use canvas is that it is only supported
by
smartphones
Also I want to generate the QR code on the fly and not store any
intermediate files in the server side (i.e.: I don't want to generate a
.png file in the server side and then link that to the page served to
the
mobile phone)

I have not checked your code base yet, I will take a look during
tomorrow
and see if I can easily add it there myself without generating code
smells
in your project

On Mon, Jul 16, 2012 at 7:12 PM, Ryan Day <
[email protected]

wrote:

it provides images from node-canvas.
i've been working on replacing this compiled dependency with an all
javascript png library ive been adapting.

in my exposed interface i have drawBitArray which is the only thing
needed
to support any other output format.
i even have a terminal renderer for viewing codes in your shell =).
kinda
silly but fun.

ill think about it a bit more.
i really didn't need the table format because my package works on the
client side in ie with excanvas. did you come to a similar
conclusion?

R

On Mon, Jul 16, 2012 at 9:03 AM, Carlos Manzanares <
[email protected]

wrote:

Hi Ryan,

certainly!
the only thing I need is to have the Img and Table support, which I
guess
should be fairly straightforward in your module (I guess it is
about
'undeleting' code)

regards,
--Carlos--

On Mon, Jul 16, 2012 at 3:58 PM, Ryan Day <
[email protected]

wrote:

?? =)


Reply to this email directly or view it on GitHub:
#1


Reply to this email directly or view it on GitHub:

#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)

@cmanzana
Copy link
Owner

Hi,

that would be so great!
as soon as you have it let me know so that I take yours into use and I
delete mine

--Carlos--

On Thu, Jul 19, 2012 at 5:27 PM, Ryan Day <
[email protected]

wrote:

im removing the dependency on node canvas for an all js png implementation.
probably by the end of the week.
acceptable?

canvas was such a small part so as long as i can generate png data and
base64 encode it i can get it going.

R
On Thu, Jul 19, 2012 at 6:59 AM, Carlos Manzanares <
[email protected]

wrote:

Hi Ryan,

I have taken a look to your module, and unfortunately your dependency to
canvas creates quite some issues for my project
I am hosting my project in heroku and the options to get canvas to run
there are not very appealing (see:
https://github.com/LearnBoost/node-canvas/wiki/Installation-Heroku)
unfortunately I do not see other way to solve this issue than to have two
different modules:

  • one that depends on canvas (your module)
  • one that does not depend on canvas (my module)

I know this is far from optimal, so let me know if you have some other
suggestions

--Carlos--

On Mon, Jul 16, 2012 at 8:50 PM, Ryan Day <
[email protected]

wrote:

i mean my code uses canvas on the server side to output images and data
uris for that.
anyway ill do some thinking on how to ratify our differences after work
=)

its awesome to see you so involved. i love making modules!

R

On Mon, Jul 16, 2012 at 9:34 AM, Carlos Manzanares <
[email protected]

wrote:

my use case is so that I would like to display the QR code from all
kind
of mobile phones (including featured phones)

initially I tried doing the computation from the client side directly
(using directly the qrcode.js), but this was too intensive for old
symbian
phones (my old Nokia E75 was unresponsive for few minutes when trying
to
generate the QR code)
this was the reason why I decided to move the processing to the
server
side
(node.js) and generate the QR code on the fly and just feed the

or tag back to the mobile phone The reason why I don't want to use canvas is that it is only supported by smartphones Also I want to generate the QR code on the fly and not store any intermediate files in the server side (i.e.: I don't want to generate a .png file in the server side and then link that to the page served to the mobile phone)

I have not checked your code base yet, I will take a look during
tomorrow
and see if I can easily add it there myself without generating code
smells
in your project

On Mon, Jul 16, 2012 at 7:12 PM, Ryan Day <
[email protected]

wrote:

it provides images from node-canvas.
i've been working on replacing this compiled dependency with an all
javascript png library ive been adapting.

in my exposed interface i have drawBitArray which is the only thing
needed
to support any other output format.
i even have a terminal renderer for viewing codes in your shell =).
kinda
silly but fun.

ill think about it a bit more.
i really didn't need the table format because my package works on
the
client side in ie with excanvas. did you come to a similar
conclusion?

R

On Mon, Jul 16, 2012 at 9:03 AM, Carlos Manzanares <
[email protected]

wrote:

Hi Ryan,

certainly!
the only thing I need is to have the Img and Table support,
which I
guess
should be fairly straightforward in your module (I guess it is
about
'undeleting' code)

regards,
--Carlos--

On Mon, Jul 16, 2012 at 3:58 PM, Ryan Day <
[email protected]

wrote:

?? =)


Reply to this email directly or view it on GitHub:
#1


Reply to this email directly or view it on GitHub:

#1 (comment)


Reply to this email directly or view it on GitHub:

#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)


Reply to this email directly or view it on GitHub:
#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants