Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you could add extra toolbar buttons, which ones do you prefer most? #3257

Open
clsid2 opened this issue Jan 29, 2025 · 17 comments
Open

If you could add extra toolbar buttons, which ones do you prefer most? #3257

clsid2 opened this issue Jan 29, 2025 · 17 comments

Comments

@clsid2
Copy link
Owner

clsid2 commented Jan 29, 2025

You can give a list of at most 5 new buttons. Order them based on which ones you want most.

Rules:

  • Do NOT discuss anything else than answering the simple question I asked above.
  • Do NOT give comments about hiding buttons. Everything will be customizable if extra button options will be added in future.
  • Do NOT list more than 5.
  • Do NOT ask when this will be implemented. The answer is "unknown, maybe newer".
  • Do NOT annoy me.
  • The button must correspond to functionality that is already available in the player. Do no try to mask a feature request as a button suggestion.

Those who choose the ignore the rules will be blocked permanently.

=====================================================

Approved buttons:

  • Options
  • Audio streams
  • Subtitle streams
  • Toggle fullscreen
  • Toggle playlist
  • Toggle shuffle
  • Generic button (x3) that can be assigned a custom left-click and right-click action

Other likely additions:

  • Seek back/forwards (with either medium jump as left-click and large jump as right or other way around)
  • Toggle repeat

Maybe:

  • Open file (already possible now as right-click action on Play button)
  • Close player (there already is exit option in right-click menu, plus Alt+F4 and Alt+X)

Probably not:

  • Video frame mode toggle

Declined:

  • Stop after (is more suitable as an after playback event)
@Nekroz88
Copy link

Nekroz88 commented Jan 29, 2025

  • No.1: Toggle repeat mode (ON = Repeat forever, OFF = Do nothing)
  • No.2: Toggle fullscreen mode (useful for people who remove Mouse Double Click as shortcut, because like me still sometimes play Flash games within MPC-HC and spam click a lot)
  • No.3: Fast seek forward (medium - like shortcut in settings)
  • No.4: Fast seek backward (also medium - like shortcut in settings)
    Normally I like to use scroll wheel for fast seeking. But I think this would be useful for people who don't like to use keyboard shortcuts or scroll wheel like me, and instead, like to click buttons
  • No.5: Toggle show/close playlist window (not available if player is handling only 1 file)

I don't know if any of my suggestions may be considered, but thank you regardless. I just saw your TODO to place playback time next to seek bar, that's something godsend for people who like to hide status bar for compact look like me.

@bibsp
Copy link

bibsp commented Jan 30, 2025

1. Audio, Subtitle buttons. Use icon. Text doesn't look good.

Image
Image

2. Info button. This will directly open MediaInfo page.
Edit: If MediaInfo is not possible then open Properties window.

Image

3. Playlist on/off button.

Image

4. Video frame button.

Image

This button will cycle these 4 options.

Image
Don't open dropdown options. Instead cycle these options on each click.

And I imagine these buttons on the right side of toolbar.

@adipose
Copy link

adipose commented Jan 30, 2025

FYI I have some recent code for toolbar improvements. It's not ready to share yet.

@clsid2
Copy link
Owner Author

clsid2 commented Jan 30, 2025

I have some ideas written down for the toolbar redesign. I will create a new issue for that soon to discuss that. Including writing a specification for graphic designers.

  • Loading from ./toolbar/[name]/ so multiple toolbars can be bundled and user can choose one in options
  • Each toolbar consists of 8 files: light/dark and in 24/32/48/64 sizes. Having multiple sizes allows better quality and more detail in larger sizes.
  • PNG or SVG. Where SVG allows scaling.
  • Option to center all buttons in middle of toolbar.
  • Toolbar image contains two rows, one for enabled button state and one for disabled/greyed out state. Or on/off for toggles.
  • Two/three generic buttons which allow specifying custom action for both left and right click.
  • Options page to specify which buttons to show (and maybe in which order)(and maybe with empty space separators that can be in the list to group buttons)

@clsid2
Copy link
Owner Author

clsid2 commented Jan 30, 2025

Another future idea is ability to choose between different seekbar design styles or color variations.

For example a thin track with round gripper. A modern take on the classic style seekbar. Like in potplayer:
Image

@sunyc
Copy link

sunyc commented Feb 1, 2025

i want playlist button

@clsid2
Copy link
Owner Author

clsid2 commented Feb 6, 2025

@irwir
Copy link

irwir commented Feb 8, 2025

Stop after current, as in foobar2000, to make a break in playback after a song or a chapter.
This function was found to be very useful.

@clsid2
Copy link
Owner Author

clsid2 commented Feb 11, 2025

You can let each (next) file start in paused state by using:
options > playback > play 0 times

@irwir
Copy link

irwir commented Feb 11, 2025

Thanks for the tip, but setting "0 times" is a bit of fuss.
It did not work with chapters, and each track had to be started manually.
While in foobar2000, the menu item Playback > Stop after current is a toggle; it would be automatically reset at the end of the track. Resumed playback would be uninterrupted.

@clsid2
Copy link
Owner Author

clsid2 commented Feb 11, 2025

Implementing such a thing for chapters is certainly not going to happen. I am not interested in doing that. And "stop after playback" is more suitable as an after playback event. So such a button will not get added either. And I am currently not adding new features at all, so you are out of luck.

@The-Choo-Choo-Shoe
Copy link

The-Choo-Choo-Shoe commented Feb 12, 2025

The 2 buttons I'd love to have is 1 for audio and 1 for subtitle, similar to MPC-BE.

A button to close the window would also be nice as there is no easy way to close the window if you have disabled the window frame and MPC-HC has no overlay buttons when this setting is enabled, might be a stretch to have a close button on the toolbar though.

@adipose
Copy link

adipose commented Feb 15, 2025

4. Video frame button.

Image

This button will cycle these 4 options.

Image
Don't open dropdown options. Instead cycle these options on each click.

I have an idea for this that could be a model for others:

  1. Left click = rotate option
  2. Right click = submenu with option

The rotate could be a limited subset or possibly it could be the last 3 selected options or something.

@bibsp
Copy link

bibsp commented Feb 15, 2025

Hello clsid, please consider adding MediaInfo button. Seeing complete details of the video file will be much easier with just one click. I'm not going to further argue with you. This is just my humble request. Thanks.

@adipose
Copy link

adipose commented Feb 16, 2025

Hello clsid, please consider adding MediaInfo button. Seeing complete details of the video file will be much easier with just one click. I'm not going to further argue with you. This is just my humble request. Thanks.

Why not add as number 5 of your list?

Perhaps there is no specific shortcut for mediainfo.

@bibsp
Copy link

bibsp commented Feb 16, 2025

Why not add as number 5 of your list?

It's already there in my list. Number 2.
I didn't find it in clsid's approved list. So I requested.

@adipose
Copy link

adipose commented Feb 16, 2025

Why not add as number 5 of your list?

It's already there in my list. Number 2.
I didn't find it in clsid's approved list. So I requested.

I see. You could suggest a properties page as that is a direct dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants