Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS Provider V5 #56

Closed
wants to merge 12 commits into from
Closed

Support AWS Provider V5 #56

wants to merge 12 commits into from

Conversation

max-lobur
Copy link
Contributor

@max-lobur max-lobur commented Jun 13, 2023

what

Support AWS Provider V5
Major release due to breaking change in S3 upgraded module
Linter fixes

why

Maintenance

references

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

@max-lobur max-lobur added the no-release Do not create a new release (wait for additional code changes) label Jun 13, 2023
@max-lobur max-lobur requested review from a team as code owners June 13, 2023 10:19
@max-lobur max-lobur requested review from Gowiem and joe-niland June 13, 2023 10:19
@max-lobur max-lobur added major Breaking changes (or first stable release) and removed no-release Do not create a new release (wait for additional code changes) labels Jun 13, 2023
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur enabled auto-merge (squash) June 13, 2023 16:55
@max-lobur
Copy link
Contributor Author

/terratest

examples/complete/outputs.tf Show resolved Hide resolved
@goruha
Copy link
Member

goruha commented Jun 21, 2023

@max-lobur can you fix all tests outputs like @Nuru asks

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah just seeing @Nuru's request. Looks like a legit request 👍

@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 2, 2024

not expecting this to be finished given the comments in the sweetops slack

@hans-d hans-d closed this Mar 2, 2024
auto-merge was automatically disabled March 2, 2024 19:34

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking changes (or first stable release) stale This PR has gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants