Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non VPC ES shouldn't require roles to whitelist ips #136

Closed
wants to merge 4 commits into from

Conversation

filipe-cantarelli
Copy link

what

  • Changed default creation logic so it also creates when it is a non VPC ES and at least one allowed_cidr_block is specified

why

NON VPC ES shouldn't require roles in order to whitelist ips

@filipe-cantarelli filipe-cantarelli requested review from a team as code owners June 7, 2022 01:16
@hans-d hans-d added stale This PR has gone stale wip Work in Progress: Not ready for final review or merge and removed stale This PR has gone stale wip Work in Progress: Not ready for final review or merge labels Mar 8, 2024
Copy link

mergify bot commented Mar 8, 2024

This pull request is now in conflict. Could you fix it @filipe-cantarelli? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Mar 9, 2024
Copy link

mergify bot commented Mar 9, 2024

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot closed this Mar 9, 2024
Copy link

mergify bot commented Mar 9, 2024

Thanks @filipe-cantarelli for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot removed the conflict This PR has conflicts label Mar 9, 2024
@mergify mergify bot removed the stale This PR has gone stale label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants