-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: AlignWide content clipped #1916
Comments
Tangent: Would be cool if we could use progressive enhancement to use the new viewport units in supported browsers |
So I see two issues here. One issue is small: The Deck block probably needs to add padding when its alignment is wide or full. Even if the scrollbar width is restored, this example shows that horizontal padding is still necessary to keep content from running into the margins. The second issue is larger: We aren't accounting for scrollbars in our calculation. That's been true of our main site since 2016, it's something I talk about in my original article. It just hasn't come up because, most of the time, those 15 pixels haven't included valuable information. The fix for that is known: Use But I have a feeling that if we solve the first issue, we'll have a lot less compelling reason to prioritize the second. And if we wait just a bit longer, we may not need the JavaScript-based fallback... So I'm going to create a separate issue for the padding thing, and I'm going to keep this issue open but out of this project as a showstopper. |
At some viewport sizes, content with the
alignwide
class is being clipped by the viewport. In the attached screenshot, the viewport is 1265px wide, but thealignwide
content is 1280px wide. I'm guessing thevw
calculations are off somehow — perhaps due to visible scrollbars?The text was updated successfully, but these errors were encountered: