Inconstistent Naming of Loadbalancing Option 'least-connection' in cloud-controller

[hoffmaen]

Due to inconsistencies with the name of the least-connection loadbalancing algorithm, it is currently impossible to use least-connection as a per-route load-balancing algorithm.

• route-registrar, gorouter, docu etc. use least-connection
• cloud_controller_ng and some parts of the documentation unfortunately use least-connections
• There is also a document from 2016 which wrongly introduces least-connections

The result is that the API only accepts least-connections, but gorouter only knows least-connection and falls back to the pool algorithm.

This introduces errors in gorouter such as:

{"log_level":3,"timestamp":"2025-01-31T12:00:15.297085107Z","message":"invalid-endpoint-load-balancing-algorithm-provided-keeping-pool-lb-algo","source":"gorouter.registry","data":{"endpointLBAlgorithm":"least-connections","poolLBAlgorithm":"round-robin"}