handleAuxUpdated causes push of empty config on startup

[ibot3]

The handleAuxUpdated function of the controller enqueues a UpdateConfigJob:

ch-k8s-lbaas/internal/controller/controller.go

Lines 309 to 313 in 84662aa

	func (c *Controller) handleAuxUpdated(obj interface{}) {
	// FIXME: it would probably be good to filter this a little instead of just
	// updating on all changes.
	c.worker.EnqueueJob(&UpdateConfigJob{})
	}

The function is called by several informers, for example nodeInformer, endpointsInformer and networkPoliciesInformer.

The problem is that this causes the function to be called several times on startup which in turn creates UpdateConfigJobs. An UpdateConfigJob is therefore run before even one SyncServiceJob has been successfully executed.
This results in an empty config to be pushed to the agent on startup.

Possible solutions:

• Subscribe to the informers only after all services have been synced once
• Increase timeout for UpdateConfigJob scheduling (enough time so that the job is not executed before the ``SyncServiceJobs`)
• ?

[ibot3]

I created a gist with the controller output log with additional log output for new enqueued jobs (job name + stacktrace):
https://gist.github.com/ibot3/e60317fdd58eecbcaaf3a8f9d4676839

The SyncServiceJobs start in line 379.