Add GC metrics to prometheus endpoints #954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: fix naming according to https://prometheus.io/docs/practices/naming/ |
|
Took it for a spin in Prometheus + Grafana via Snowstorm, a few 
I guess there's no timings for how long it spends in GC, e.g. mark, sweep? |
Yeah. Probably. It may depend on the gc lib version.
Probably not. This is what I've found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
This will make stats loop save GC.prof_stats which is then added to prometheus
metricsMetrics exported is what's in https://github.com/ivmai/bdwgc/blob/47e0ef445d1aa48b8c48ef166b117386e4e0100c/include/gc/gc.h#L795
Fixes #936
HOW can this pull request be tested?
Spin up lavinmq, then
curl -u guest:guest http://localhost:15672/metrics | grep gc_