Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin is activated on Vagrant up #6

Open
tal5ab opened this issue Apr 5, 2016 · 3 comments
Open

The plugin is activated on Vagrant up #6

tal5ab opened this issue Apr 5, 2016 · 3 comments

Comments

@tal5ab
Copy link

tal5ab commented Apr 5, 2016

See #3 how i found this issue
I am not sure if thats by design or not
But my expectations from this plugin is to be used once vagrant up finished to create the VM
So i will bring the VM up , and only then run the rspec tests with vagrant rspec

@clintoncwolfe
Copy link
Owner

Hrm, what I see is this:

  • on any vagrant command, the configuration is validated (by design)
  • on 'vagrant rspec', the tests are run

You seem to be reporting that the tests are run on other command, such as 'vagrant up'. Is that correct?

@tal5ab
Copy link
Author

tal5ab commented Apr 6, 2016

no , as far as i see , its only verifying the setup (it crashed for missing spec folder)
I agree that there is a slim chance you install a plugin and don't have the setup for it in place
but that was my experience, and simply installing this plugin made my vagrant to stop working

So one option is to only do validation when user calls vagrant rspec
Or maybe the only thing needed here is some more documentation

@clintoncwolfe
Copy link
Owner

Hrm, and all it's doing is looking for a directory. If the dir doesn't exist, a reasonable thing to do might be to create it, instead of erroring. What do you think?

And I agree, the directory structure should be documented more clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants