refactor(DirectedGraph): utilize opt.deep for fitToChildren call when resizing clusters #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
packages/joint-layout-directed-graph/DirectedGraph.mjs: Modified the cluster resizing logic to filter out top-level clusters and apply thefitToChildrenmethod in reverse-depth order, ensuring that clusters are resized starting from the deepest descendants.packages/joint-layout-directed-graph/test/index.js: Added a new test to verify that clusters are resized correctly. The test embeds multiple elements within each other, applies the layout, and checks that each parent element is resized to fit its children with the specified padding.Motivation and Context
Refactor the existing solution, while maintaining the logic and utilizing an existing
deepoption on thedia.Element.fitToChildren()method.