Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Comments #1

Open
stevejr opened this issue Apr 23, 2019 · 1 comment
Open

Review Comments #1

stevejr opened this issue Apr 23, 2019 · 1 comment

Comments

@stevejr
Copy link

stevejr commented Apr 23, 2019

@clemenko - Some comments from me:

  • Amend all references of Docker EE or "Enterprise Edition" to Docker Enterprise
  • At DockerCon in Barcelona we used my fork as I updated the screenshots, some of the text etc - did you compare against that? - https://github.com/stevejr/dc18_supply_chain
  • Maybe update the docker client commands to use the full primitives i.e. docker image pull instead of docker pull? Again, I did this in my dc18 fork
  • Statement Do worry if you see images in a Scanning...orPending state. Please click to another tab and click back. should read Don't worry if you see images in a Scanning...orPending state. Please click to another tab and click back.
  • Did you drop Task 6.2 - Manually Promote Image on purpose?
  • I amended Task 9.3 - Webhooks in my fork to use the Generic Webhook plugin - not sure if you want to do the same?
  • I added an optional Task 10 in my fork to bring it altogether in Jenkins. We did manage to get thru it so not sure if you want it in yours or not?
@clemenko
Copy link
Owner

Thanks @stevejr. I did remove Task 6.2 - Manually Promote Image. I thought it was a counter to the whole Automation thing. I didn't see the point of adding a Jenkins Plugin for "Generic Webhook" when the functionality is already there.
I think the skill level of the audience won't want to dig deep into the pipeline stuff. I want to make this a little more approachable for the target audience. Make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants