Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candidate patches #651

Open
classilla opened this issue Dec 9, 2021 · 12 comments
Open

candidate patches #651

classilla opened this issue Dec 9, 2021 · 12 comments

Comments

@roytam1
Copy link

roytam1 commented Dec 17, 2021

maybe also https://hg.mozilla.org/projects/nss/rev/7d4f221b1fffcad72b18175b89e4d310307277ef for accessing microsoft.com

@roytam1
Copy link

roytam1 commented Jan 6, 2022

maybe also https://hg.mozilla.org/projects/nss/rev/7d4f221b1fffcad72b18175b89e4d310307277ef for accessing microsoft.com

regarding rev fd2b82f , security/pkix need same fix as well.

@classilla
Copy link
Owner Author

https://hg.mozilla.org/releases/mozilla-esr91/rev/3b54d6b5407fca03efdb2e2f57a9838498e0d038 (and backbug on aRead = 0)
https://hg.mozilla.org/releases/mozilla-esr91/diff/d8503523b4cc610ec3bade0787f200afdef738e6/security/nss/lib/pki/trustdomain.c (simplify, we don't need all the (void) casts)
https://hg.mozilla.org/releases/mozilla-esr91/rev/d6b476cadd24b6e845de7853a19e71ba62c8a58d
Not sure if this actually fixes anything, but it seems "right": https://hg.mozilla.org/mozilla-central/rev/d8b66c3db775

Finally, add the DoubleCondition branch fix discovered on the POWER9 JIT, and look to see if the f32 bailout problem affects us as well.

We also need to wholesale pull-up modules/zlib to get bug 1761799. That might be a little later.

@classilla
Copy link
Owner Author

After testing, the DoubleCondition branch fix seems to go into an infinite loop on some sites, so deferring that; the branching code is somewhat different. But it does have the F32 bailout problem, and fixing that seems to stick.

classilla added a commit that referenced this issue May 1, 2022
@classilla
Copy link
Owner Author

EV roots: update /security/certverifier/ExtendedValidation.cpp to 102
update /security/nss/lib/ckfw/builtins/certdata.txt to 102
add fx102 key to user agents
update STS preload script and upcert scripts
set CLOBBER

classilla added a commit that referenced this issue Sep 18, 2022
…M1773717; mark clobber; fix zlib warning; now officially on 102ESR
classilla added a commit that referenced this issue Sep 25, 2022
@classilla
Copy link
Owner Author

classilla commented Jan 30, 2023

Through b07b4373ed3f7b392b2457b535c953176491de7b

https://hg.mozilla.org/releases/mozilla-esr102/rev/7b43b4ab4275 (different files in dom/html, note nsCOMPtr versions of CSP objects)
https://hg.mozilla.org/releases/mozilla-esr102/rev/80ecb3c8668b to nsCookieService.cpp
https://hg.mozilla.org/releases/mozilla-esr102/rev/084a542649289e7f4ad7636e24bb6588b1c2c63a target[size] to target[written] (readlink is called in two places but only one is wrong)
https://hg.mozilla.org/releases/mozilla-esr102/rev/c8dab52e2ead50f94859600571b48d9ac491c854 (we do have nsCCharSeparatedTokenizer, definitely want Xhr portion) (separate patch)
https://hg.mozilla.org/releases/mozilla-esr102/rev/bedc23ef1e13 (applies cleanly)
https://hg.mozilla.org/releases/mozilla-esr102/rev/b8cf39722afa (applies cleanly)
https://hg.mozilla.org/releases/mozilla-esr102/rev/47feff550f43 (applies cleanly)
https://hg.mozilla.org/releases/mozilla-esr102/rev/9968c9743e6aa71d64fefb57aff9242bebb801d9
https://hg.mozilla.org/releases/mozilla-esr102/rev/db6a4af87843519ecf8ce9d1285e38fafc484181 (nsPresShell.cpp:6599)
https://hg.mozilla.org/releases/mozilla-esr102/rev/f9180d5446f2b219dc06f2eafc3e14e987266f7a (add the new *loc entries to xpcom/io/nsLocalFileUnix.cpp)
https://hg.mozilla.org/releases/mozilla-esr102/rev/a6a77bf24308ab50226595c7623ff47c6bd606c3 (in dom/base)

deferred
:: https://hg.mozilla.org/releases/mozilla-esr102/rev/a4167befb70526e788c4eba9ee12925c764d40a0 needs plumbing apparently but we might want it
:: I don't think we're affected by https://hg.mozilla.org/releases/mozilla-esr102/rev/db9a92d5466c11e09d0e0c9a2813df175e7c7d42 but marking here for future check when the bug is open.
:: https://hg.mozilla.org/releases/mozilla-esr102/rev/c581112d97d4 if testcase https://bugzilla.mozilla.org/show_bug.cgi?id=1787633 generates debug assert (probably separate patch)
:: not sure what https://hg.mozilla.org/releases/mozilla-esr102/rev/48049cc5b3a854e027d8e3812fcaa07ec3670443 is fixing
:: not sure what https://hg.mozilla.org/releases/mozilla-esr102/rev/69926147e2c52ccd18f99944370ab6e6c3870077 is fixing, we go through the queue twice

@classilla
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants