Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update font blacklist #566

Open
classilla opened this issue Aug 13, 2019 · 22 comments
Open

Update font blacklist #566

classilla opened this issue Aug 13, 2019 · 22 comments

Comments

@classilla
Copy link
Owner

From https://tenfourfox.tenderapp.com/discussions/problems/8844-waste-management-have-broken-themselves-on-tenfourfox-with-their-new-and-improved-yeah-right-website
classilla added a commit that referenced this issue Aug 14, 2019
@classilla
#566: update font blacklist
2591f0e
@classilla
Copy link
Owner Author

Tested working

@chris-chtrusch
Copy link
Collaborator

https://www.kulturstiftung-des-bundes.de/typo3conf/ext/base_ksb/Resources/Public/38c1bdeb69b2cae2f59fae38f127aa6d.woff2

https://www.kulturstiftung-des-bundes.de/typo3conf/ext/base_ksb/Resources/Public/9437aea92626957f9d7fd0e5f548b689.woff2

@classilla
Copy link
Owner Author

Okay, will add for FPR17.

classilla added a commit that referenced this issue Nov 22, 2019
@classilla
#566: and a couple more
916d37b
@chris-chtrusch
Copy link
Collaborator

Is it possible to blacklist https://www.kulturstiftung-des-bundes.de/typo3conf/ext/base_ksb/Resources/Public/*.woff ?
They seem to switch this part of the URL every once in a while.

@classilla
Copy link
Owner Author

Yes, I'll change the entry. It's designed so that it can match on partial URLs.

@classilla classilla reopened this Nov 24, 2019
classilla added a commit that referenced this issue Dec 2, 2019
@classilla
#566: change to partial match
3f21b5a
@chris-chtrusch
Copy link
Collaborator

https://cdn.trustpilot.net/brand-assets/2.1.0/fonts/trustpilot-default-font-regular.woff2
https://cdn.trustpilot.net/brand-assets/2.1.0/fonts/trustpilot-default-font-medium.woff2
https://cdn.trustpilot.net/brand-assets/2.1.0/fonts/trustpilot-default-font-bold.woff2

@classilla
Copy link
Owner Author

I'll pick this up for FPR21 since FPR20 is already halfway through build and certify.

@classilla classilla reopened this Mar 7, 2020
@chris-chtrusch
Copy link
Collaborator

Trustpilot still has these font issues.

@classilla
Copy link
Owner Author

Damn it, this slipped. I'll get for final.

classilla added a commit that referenced this issue Apr 5, 2020
@classilla
#566: trustpilot
72ed78a
classilla added a commit that referenced this issue Apr 5, 2020
@classilla
#566: adac, swr3
70020aa
@classilla
Copy link
Owner Author

New sets landed, tested working.

@chris-chtrusch
Copy link
Collaborator

https://hartzfacts.de/google-fonts/s/notoseriftc/v7/XLY9IZb5bJNDGYxLBibeHZ0Bvr8vXX5MTw.woff2

https://hartzfacts.de/google-fonts/s/notoseriftc/v7/XLY9IZb5bJNDGYxLBibeHZ0BvtssXX5MTw.woff2

https://hartzfacts.de/google-fonts/s/notoseriftc/v7/XLYgIZb5bJNDGYxLBibeHZ0BtnAOSA.woff2

https://hartzfacts.de/google-fonts/s/notoseriftc/v7/XLY9IZb5bJNDGYxLBibeHZ0BvoMtXX5MTw.woff2

https://hartzfacts.de/google-fonts/s/notoseriftc/v7/XLY9IZb5bJNDGYxLBibeHZ0BvvMpXX5MTw.woff2

@classilla classilla reopened this Jul 11, 2020
@classilla
Copy link
Owner Author

Ack'ed for FPR25

classilla added a commit that referenced this issue Jul 16, 2020
@classilla
#566: hartzfacts.de
8034a1e
classilla added a commit that referenced this issue Mar 31, 2021
@classilla
#566: theatlantic.com
6374793
classilla added a commit that referenced this issue Apr 17, 2021
@classilla
#566: icloud.com
1db2c61
classilla added a commit that referenced this issue Oct 4, 2021
@classilla
#566: another bad gfont
f091deb
@chris-chtrusch
Copy link
Collaborator

I found two more fonts to add to the font list. For my own build I did this at gfxPlatformMac.cpp:

	EXACT_URL("https://som.yale.edu/themes/custom/som/fonts/neuehaasunica/NeueHaasUnicaBlackItalic/italic_normal_subset1.woff2");

	EXACT_URL("https://som.yale.edu/themes/custom/som/fonts/neuehaasunica/NeueHaasUnicaBlack/normal_normal_subset1.woff2");

This worked, but EXACT_URL is probably the least generic/desirable place to add it.

@classilla
Copy link
Owner Author

How about

HTTP_OR_HTTPS_SUBDIR("som.yale.edu","/themes/custom/som/fonts/neuehaasunica/NeueHaasUnicaBlack");

Or does that block too many things?

I'm getting together another patch drop, so I'll include this blocklist update.

@chris-chtrusch
Copy link
Collaborator

That should work as well. This being my first try to manipulate the font list I simply didn't know how to use the more generic methods.

Should I keep posting fonts here or is there a way to contribute directly, i.e. submit changes for review? The Unofficial TenFourFox Development Toolkit I use to build the browser doesn't have full Git functionality, I can merge my local changes when I re-download the source, but cannot "push" my changes upwards.

@classilla
Copy link
Owner Author

Officially the only way Github does it is to set up a full pull request, which isn't ideal. Oh well.

Short of manually posting URLs, one other option is to do a git diff with your changes and post the diff. I'm okay with either.

classilla added a commit that referenced this issue May 1, 2022
@classilla
#566 and #651: update font blacklist, M1754724, M1758062, M1761026+ba…
700da3e 
…ckbugs, M1755555, M1663508, M1719215
@classilla
Copy link
Owner Author

You may want to remove your local change before pulling or you'll get a merge conflict, but this is now upstreamed.

@chris-chtrusch
Copy link
Collaborator

https://www.washingtonpost.com/wp-stat/assets/fonts/PostoniWide-Regular.woff2
https://www.washingtonpost.com/wp-stat/assets/fonts/PostoniWide-Bold.woff2

classilla added a commit that referenced this issue Sep 18, 2022
@classilla
#566: wapo
16f6279
@chris-chtrusch
Copy link
Collaborator

Major liberal German Newpaper did a site re-design without consulting TenFourFox.

https://assets.tagesspiegel.de/fonts/Abril_Text_Regular-basic.c371b6fb87298eb4990a97124a47e7e4.woff2

https://assets.tagesspiegel.de/fonts/Abril_Text_Regular-extended.413ee6f014cfa7c05f2979ccb6498cee.woff2

https://assets.tagesspiegel.de/fonts/Abril_Text_Italic-basic.6c5932e5019579d6c76d1822e5aacc4d.woff2

https://assets.tagesspiegel.de/fonts/Abril_Text_Bold-extended.7e1a83a609780222181670109982a7a2.woff2

https://assets.tagesspiegel.de/fonts/Abril_Text_Bold-basic.ed72f8ea0597f63d7cc1a47ae7bb3acd.woff2

https://assets.tagesspiegel.de/fonts/Abril_Text_BoldItalic-basic.1cd71e407d313b5db30f65b5a9bc639f.woff2

https://assets.tagesspiegel.de/fonts/franklingothic-book-extended.b0f1fe099d20b0de899ed94f6292ba63.woff2

https://assets.tagesspiegel.de/fonts/franklingothic-book-other.6c8ff800d4fec0ff804a756fc400d2b5.woff2

https://assets.tagesspiegel.de/fonts/franklingothic-book-basic.c62561d04e5eb023ca3e2fde512605c0.woff2

https://assets.tagesspiegel.de/fonts/franklingothic-med-extended.e84bf4c79c0055f692e535db121cff4a.woff2

https://assets.tagesspiegel.de/fonts/franklingothic-med-basic.4262342c15da29dbdffaff795d31ad13.woff2

@classilla
Copy link
Owner Author

Noted, thank you. Probably will do a regular update around now too.

classilla added a commit that referenced this issue Apr 16, 2023
@classilla
#566: tagesspiegel.de
2521b95
@chris-chtrusch
Copy link
Collaborator

https://www.tagesschau.de/resources/assets/fonts/TheSansC5s-4_SemiLightItalic.woff2
https://www.tagesschau.de/resources/assets/fonts/TheSansC5s-4_SemiLight.woff2
https://www.tagesschau.de/resources/assets/fonts/TheSansC5s-6_SemiBold.woff2

@classilla
Copy link
Owner Author

Noted and landing shortly

classilla added a commit that referenced this issue Aug 31, 2023
@classilla
update ESR base to 115; update EV roots, certs, HSTS, pins, TLDs, TZs…
55284dd 
…; update usrsctp; security pullup; more comprehensive nuisance script blocking; fixes for #488, #566
classilla added a commit that referenced this issue May 5, 2024
@classilla
#566: linuxconfig.org
7b77839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@classilla @chris-chtrusch