-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localized versions for feature parity #328
Comments
Updated Locale installers with copyright 2018, fix for print/open/save dialogs and allowing for 'FPRx.y' version strings up to FPR10.5 in the version check routine. I did not use placeholders so we can easily exclude earlier versions of the browser when new custom strings or other changes are introduced that would make the installers incompatible with these versions. Also renamed the installers to show 'FPR' since '45' probably confuses people by now. TFF-FPR.x-Langpack-Finnish.app.zip |
Thanks. Will update on my return (typing from the Death Valley Ranch).
|
Replaced on home page. |
How could one join in on translating TFF? |
Look at https://github.com/classilla/tenfourfox/wiki/Localization . If you feel able to do so, post the pack as an attachment here and we can get it processed for general availability. |
There are slight changes in the About Dialog credits/contributers list starting with FPR6. Modified the German installer accordingly. I think it should be sufficient to slip this in for all installers on occasion when something else needs to be fixed or updated. |
Do you mean you had to carry the names over? I thought if you just didn't specify that key in the locale, the default English would be used. If there is some English in there, then I should probably fix that at some point.
|
The key is <!ENTITY contribute.start … and yes, there's some English in it. |
Localizations need updates for samesite cookie support in the developer tools. At the same time I'll update the version checker for versions >FPR10 because we're getting near that number, and remove support for <FPR8. We should keep an archive of the installers valid for up to FPR 7. Also I'll update contributers in the about dialog. Will post installers here shortly. |
Great, I will upload these installers with FPR8 final. Thanks!
|
Uploaded and live. |
will it be a chinese version? |
It can be done. Do you mean Simplified or Traditional Chinese? The problem is that, unlike Latin, Cyrillic and a little Greek, I'm illiterate in Chinese. I need a volunteer (native speaker if possible) to do quality control and translate a few text strings for functionality that is only in TenFourFox, not in Firefox. Can you do this? |
I need to update the © date in the about dialog, also update the version checker for TFF 14ff. While I'm at it: Any new strings to add? |
I'm native speaker, 2 years user of TFF and glad to help the translation of TFF in Simplified Chinese. https://github.com/classilla/tenfourfox/wiki/Localization I read that but it's quite hard for me to understand. Could you please guide me to join the translation if there's a easier way |
Paizhangpi, I'm just going to need the strings in the attached text file translated to Simplified Chinese, then I can start making the installer app. Thank you! |
(The Applescript dialogs will have to stay English because Applescript for 10.4 doesn't support non-ascii characters.) |
Thank you! I will make the installer during the next weekend. I'll try to use the complete sentence in the About Tenfourfox dialog, I suspected such a problem :-) I forgot this string for the About Tenfourfox dialog: |
That's no problem at all. TenFourFox let my powerful PowerPC Mac reborn, so I'm happy to join the translation of my native language. Feel free to contact me for further problem. Mozilla Community Credits |
If the MP4 stuff sticks, we might expose that pref. I haven't decided yet, but an "Enable H.264 video" couldn't hurt, I suppose. It's not critical however. |
Alright, I'll add these; since the grammar should be consistent and we have enough other things that can be 'enabled' I could even translate this myself. I'm planning to upload all new installers incl. Chinese on the weekend. |
Cameron, can we go with ENTITY TFFh264.title "H.264 video" in TenFourFox.dtd, and TFFh264.title.p = H.264 video in TenFourFox.properties? |
I was thinking about that. I think it might be better for the prompt to be "Enable H.264 video (requires MP4 Enabler)" but I don't know how feasible that would be with the extra localization phrase. Your call. |
I'll leave the parentheses in English if I'm unsure and change it in a later edition, it's not being exposed right now anyway. |
Langpack installers updated for FPR 14+. Changes: TFF-FPR14-Langpack-Spanish.app.zip |
German test installer for FPR 28 and up. Added "Enable JavaScript" translation. |
I don't know if I'm going to use these, but let's add these or something like it as well while we're doing it: "Domain" (this may be already there) This is for an idea I have about per-domain configuration. Not sure how feasible it is yet. Let me know if these strings will be troublesome. |
Should these go in browser.dtd? |
German test installer for TFF FPR 29. Please test. Two things:
|
I'm not on the G5 at the moment, but I think it's the tooltip for the "book" icon. I'm fine with a more culturally appropriate translation. :) |
(It probably shouldn't be enabled on about:blank pages either. That's a separate bug.) |
The Toolbar tip for the Book icon is 'Toggle Reader View', that's what we localize in browser.properties. 'Toggle Reader Mode' in browser.dtd seems to be the string for the View Menu item which shouldn't be visible anytime, I agree. What I don't understand is: Why do we need it in the first place? Is it necessary so that the ⌥R command works, or is it a placeholder for 'Enter/Close Reader View'? |
I'm fine with treating it as a placeholder, but I think it's still needed for the XUL. |
I think my German test installer for 29 is technically o.k., then. I'll make the other ones accordingly. |
Uploaded to SourceForge. Thanks, Chris! |
We need new translations for site specific user agents and reader view. Please edit the file strings-for-31fpr.txt (attached) and re-attach it to your post. If you keep the structure of the lines and item tags you make my life easier when I assemble the langpack installers. Thank you! Some hints, because much of the work has already been done: Have a look at the wording that's already in the TenFourFox preferences pane and elsewhere (strings such as 'user agent'; 'reader view', 'custom' etc.) and keep your translations consistent. Strings such as 'site specific', 'predefined', 'sub pages' or 'mode' have already been translated in other contexts for modern versions of Firefox (e.g. 'create site specific notes'; 'enable night mode' etc.); please check pontoon.mozilla.org and decide whether the translations found there make sense in our context. It's your decision as a native speaker, but I'd like to keep translations as consistent to Firefox as possible. Keep in mind that the user agent feature is actually domain specific, i.e. you cannot define a single page with a /. Try to be specific in your wording (domain/website vs. web page).
German test installer for TFF 31 FPR: |
French |
Italian (it was not that difficult ;-) ) |
Are we OK launching with the Site Specific dialogue, or do we want to wait a cycle? I can disable it for release and reenable for the next beta. I need to start the build in the next 24 hours to have sufficient time for testing. |
Technically, we're OK. We won't have all translations ready in time, but that would also be true if we waited one more cycle (we haven't had contributions for some languages in ages). The new UI parts can stay English for the time being, I can add whatever arrives later at the next occasion. French+Italian+German cover ~75% of the user base for localizations. |
OK, thanks. If you change your mind I'll still be working on it a few more hours to finish and certify the security review, and then I'll start the build overnight. |
Updated installers for FPR 31. Changes: Set © date to 2021; added strings for auto reader view and site specific user agent, updated version check routine. Thank you @nodarkthings for contributing French & Italian translations. Languages other than German, French and Italian have the new UI parts in English to make the XUL work. Translations for these can still be added at a later stage. If you're able to help, please contribute. It's only a few lines. The UI parts affected are mostly variable in width and hight, so you don't even have to get too creative this time to constrain your text length (which is always a challenge, at least for German). TFF-FPR31-Langpack-Chinese-simplified.zip |
If no one ever applies for the Spanish translation, just ask me before next release or when you feel appropriate. I haven't done it this time because I thought it would be one of the easiest languages for which to find a native speaker... And also because I'm not sure my translation would be reliable enough — but I think it probably would be 90% ok, anyway. ;-) |
If worst comes to worst, I can do the Spanish translation. I'm not a native speaker either but I speak it regularly. |
It's not my final decision, but having worked as a professional translator for almost a decade I find it hard to abandon Rule Number One that the target language must be your native language, or at least the text must be proof-read by a native speaker before publication. |
I don't disagree. Just another option. |
Seeing auto reader view in action in FPR 32 required a semantic correction in the German translation. |
Uploading as a running change. |
The langpack installers will stop working after FPR 32.3 (45.41.3) since I didn't expect there to be more than four minor versions per FPR version. Should I update the installers with a new version check routine for 32.x one last time? Or (better perhaps) put a readme in the SourceForge directory telling people how they can extend the check routine by themselves (it's a simple list in the AppleScript)? |
Is both possible? Then future builders will know what to do, but at least the legacy users are taken care of until the end. |
OK, I'll upload the installers to langpacks/FPR32 plus a readme.markdown with instructions for builders how to adjust the version check routine. What's the number that ends up being displayed as "Version" in the Finder column view? config/milestone.txt or browser/config/version.txt? They both currently have '45.41.3'. |
They should always match but that particular string always comes from
|
This will involve custom strings.
See #42 for history.
The text was updated successfully, but these errors were encountered: