Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Remove use of derecated api_server_access_profile. vnet_integration_enabled #14

Open
mloskot opened this issue Aug 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mloskot
Copy link
Contributor

mloskot commented Aug 22, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Warning: Argument is deprecated

│   with module.stack_aks.module.aks.azurerm_kubernetes_cluster.aks,
│   on .terraform/modules/stack_aks.aks/r-aks.tf line 28, in resource "azurerm_kubernetes_cluster" "aks":
│   28:     vnet_integration_enabled = var.vnet_integration.enabled

│ This property is not available in the stable API and will be removed in v4.0 of the Azure Provider. Please see https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/4.0-upgrade-guide#aks-migration-to-stable-api for
│ more details

That is due to the following features being deprecated:

api_server_access_profile.subnet_id is deprecated and removed in 4.0
api_server_access_profile. vnet_integration_enabled is deprecated and removed in 4.0

To be honest, I'm not quite sure what the following should be replaced with, if anything:

api_server_access_profile {
authorized_ip_ranges = var.private_cluster_enabled ? null : var.api_server_authorized_ip_ranges
vnet_integration_enabled = var.vnet_integration.enabled
subnet_id = var.vnet_integration.subnet_id
}

New or Affected Resource(s)/Data Source(s)

azurerm_kubernetes_cluster

Potential Terraform Configuration

No response

References

@mloskot mloskot added the enhancement New feature or request label Aug 22, 2024
@Shr3ps
Copy link
Member

Shr3ps commented Aug 23, 2024

And now v4 is out, we will have lots of work to rework all our modules 😓 yeah

@mloskot
Copy link
Contributor Author

mloskot commented Aug 23, 2024

As a user of your modules, I'll appreciate that and I'll also try to contribute to the overhaul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants