Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--tps and --fps mixed up? #22

Open
charklie opened this issue May 11, 2024 · 5 comments · Fixed by #23
Open

--tps and --fps mixed up? #22

charklie opened this issue May 11, 2024 · 5 comments · Fixed by #23

Comments

@charklie
Copy link

charklie commented May 11, 2024

When ever i use --fps and set it to 140 and use --show-fps the indicator stays at 60, while if i use --tps and set it to 150 and use --show-fps the indicator shows 150.

Mabye also consider making -f and -t shorthand for --fps and --tps

@charklie
Copy link
Author

Oh yeah, star mode doesnt work either.

[charlie@charend ~]$ tenki --mode star
thread 'main' panicked at src/weather/mod.rs:19:18:
has not been implemented yet for this mode
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)

@ckaznable
Copy link
Owner

The calculation of --show-fps is not quite accurate. This was originally a flag I used for debugging.

And I haven't implemented star mode yet, so I don't have much time to do it lately 🥲

@ckaznable
Copy link
Owner

-t and -f has been released on v1.10.0

@MrDwarf7
Copy link

MrDwarf7 commented Sep 6, 2024

Would it be possible to apply similar logic sort of how video games do their calculations to de-couple tick rate & fps? Getting some weird effects happening.

I'll try and have a look over the code and see if I can fix it myself, but figure I'll raise it here as a +1

@ckaznable ckaznable reopened this Sep 6, 2024
@ckaznable
Copy link
Owner

If there's an example, I can understand what the problem is, because the way doing it now is my own interpretation, and I'm not sure it's the right one.

Anyway, more PR are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants