Provider produced inconsistent result with Azure_Ephemeral_OS_Disk as the storage type

[j7lloyd]

Error: Provider produced inconsistent result after apply
│
│ When applying changes to citrix_machine_catalog.catalog_name, provider "provider[\"registry.terraform.io/citrix/citrix\"]" produced an unexpected new value:        
│ .provisioning_scheme: inconsistent values for sensitive attribute.
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.

Subsequently, running terraform plan indicates that the resource is tainted and must be replaced:

      ~ provisioning_scheme      = {
          ~ azure_machine_config           = {
              ~ storage_type              = "Standard_LRS" -> "Azure_Ephemeral_OS_Disk"
                # (7 unchanged attributes hidden)
            }
            # (7 unchanged attributes hidden)
        }
        # (5 unchanged attributes hidden)

[aneeshk-citrix]

Hi @j7lloyd,

Thank you for reporting this issue. During what action do you see this issue? Create/Import/Update? Can you also share the terraform config, masking any sensitive attributes?

Thanks,
Aneesh

[j7lloyd]

Initially, the error arises during the creation of a machine catalog. However, an update necessitates the replacement of the resource, trapping me in a vicious cycle. Despite experimenting with different configurations, the outcome consistently persists when storage_type is set to 'Azure_Ephemeral_OS_Disk'. Hence, the fix outlined in PR #75 guarantees that the storage_type remains unchanged in this situation.

[j7lloyd]

I have conducted further testing today and found that this issue occurs when I use a machine_profile_vm – or at least it doesn't error when I use a machine_profile_template_spec – after which, the StorageType value is set to "Standard_LRS" in CustomProperties, as follows:

<CustomProperties xmlns="http://schemas.citrix.com/2014/xd/machinecreation" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
    <Property xsi:type="StringProperty" Name="Zones" Value="1" />
    <Property xsi:type="StringProperty" Name="UseEphemeralOsDisk" Value="true" />
    <Property xsi:type="StringProperty" Name="UseManagedDisks" Value="true" />
    <Property xsi:type="StringProperty" Name="LicenseType" Value="Windows_Client" />
    <Property xsi:type="StringProperty" Name="UseSharedImageGallery" Value="true" />
    <Property xsi:type="StringProperty" Name="SharedImageGalleryReplicaRatio" Value="40" />
    <Property xsi:type="StringProperty" Name="SharedImageGalleryReplicaMaximum" Value="10" />
    <Property xsi:type="StringProperty" Name="DiskEncryptionSetId" Value="**removed**" />
    <Property xsi:type="StringProperty" Name="SchemaVersion" Value="2" />
    <Property xsi:type="StringProperty" Name="OsType" Value="Windows" />
    <Property xsi:type="StringProperty" Name="StorageType" Value="Standard_LRS" />
</CustomProperties>

Consequently, I have updated PR #75 to avoid refreshing the StorageType property when UseEphemeralOsDisk is "true".

[aneeshk-citrix]

Hi @j7lloyd,

Thanks for bringing up this issue and also for opening the corresponding PR. We will have this fix included in the next release.

Aneesh