Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs/natives): improve description #963

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

PsychoShock
Copy link
Contributor

Should be good to review @4mmonium

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, requested some changes. Thank you for your contribution! 😊

@@ -8,7 +8,7 @@ ns: VEHICLE
void DELETE_SCRIPT_VEHICLE_GENERATOR(int vehicleGenerator);
```

Removes a scripted vehicle generator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way of getting the integer value for this vehicleGenerator? Some example code would be nice 😅

Copy link
Contributor Author

@PsychoShock PsychoShock Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably missing the native VEHICLE_GENERATOR_INDEX that creates a vehicle generator. R* seems to use SET_SCRIPT_VEHICLE_GENERATOR with it too.

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved, thank you! 😊

@4mmonium 4mmonium merged commit 90d54dd into citizenfx:master Apr 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants