Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joaat mixup for RemoveCurrentRise #732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chipjpg
Copy link
Contributor

@chipjpg chipjpg commented Apr 28, 2022

Changed joaat from 0x7DBCEF6F to 0x45268B6F.
0x7DBCEF6F was used to reset the calming quad counter to 0 on console. afaik it's not available on new builds.

Changed joaat from 0x7DBCEF6F to 0x45268B6F.
0x7DBCEF6F was used to reset the rise counter to 0 on console. afaik it's not available on new builds.
@fingaweg
Copy link

0x45268B6F = REMOVE_EXTRA_CALMING_QUAD

@stannum-cfx stannum-cfx added the needs validation This looks good, but needs additional confirmation of suggested change. label May 5, 2022
@stannum-cfx stannum-cfx requested a review from blattersturm May 5, 2022 17:17
@stannum-cfx
Copy link
Contributor

I'm not sure how to verify if this won't break anything, @blattersturm any ideas?

@AvarianKnight
Copy link
Collaborator

AvarianKnight commented Aug 9, 2024

I don't think jooat values are used for anything besides documenting if a name is valid or not, which this also fixes. I'll double check to make sure this does break anything before merging

@AvarianKnight AvarianKnight added merging-blocked PR is waiting for something else to be merged. and removed needs validation This looks good, but needs additional confirmation of suggested change. labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging-blocked PR is waiting for something else to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants