Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloth components are crashing client #3046

Closed
CeebDev opened this issue Dec 29, 2024 · 30 comments
Closed

Cloth components are crashing client #3046

CeebDev opened this issue Dec 29, 2024 · 30 comments
Assignees
Labels
bug crash game-bug Bugs that appear to be related to game code.

Comments

@CeebDev
Copy link

CeebDev commented Dec 29, 2024

What happened?

On the latest gamebuild (3407) some components crash the client

Expected result

It should set the component and not crash

Reproduction steps

SetPedCollectionComponentVariation(PlayerPedId(), 6, "mp_m_2024_02", 4, 0, 0);

Importancy

Crash

Area(s)

FiveM

Specific version(s)

Gamebuild 3407 / Windows b12168

Additional information

No response

@CeebDev CeebDev added bug triage Needs a preliminary assessment to determine the urgency and required action labels Dec 29, 2024
@github-actions github-actions bot added the crash label Dec 29, 2024
@spacevx
Copy link
Contributor

spacevx commented Dec 30, 2024

@Nobelium-cfx

@prikolium-cfx prikolium-cfx added game-bug Bugs that appear to be related to game code. and removed triage Needs a preliminary assessment to determine the urgency and required action labels Jan 2, 2025
@prikolium-cfx
Copy link
Collaborator

@Nobelium-cfx

Thanks, but there is no need to tag developers. I already added this bug to our internal tracking system and developer will be assigned soon.

@BurnhamR
Copy link

To add to this, We have been having frequent crashes on Gamebuild 3407 when PEDs die with the same stack trace as the cloth components.

@KillStr3aK
Copy link

not sure if its the same thing, but 3095 (probably lower versions aswell) also been crashing for a while, just one step earlier than this at sub_141304A3C (0x101) (autumn-twenty-potato)

the stack goes through the init function of CStreaming and crashes somewhere in the game

@Pundah
Copy link

Pundah commented Jan 26, 2025

not sure if its the same thing, but 3095 (probably lower versions aswell) also been crashing for a while, just one step earlier than this at sub_141304A3C (0x101) (autumn-twenty-potato)

the stack goes through the init function of CStreaming and crashes somewhere in the game

I can't say I have the same issue with 3095, but 3258 is crashing. 3258 seems to be stable for me.

@ElectriziaDev
Copy link

Hello, do you have a deadline for correcting this problem? We based ourselves on the new version to release our new server, saying that it would be corrected before our release, but we are starting to have doubts. Thank you for your feedback. Good day ! :)

@mickeygeecom
Copy link
Contributor

Hello, do you have a deadline for correcting this problem? We based ourselves on the new version to release our new server, saying that it would be corrected before our release, but we are starting to have doubts. Thank you for your feedback. Good day ! :)

+1 on this.

@TonybynMp4
Copy link

Yeah i wouldn't expect cfx to fix this ever tbh lol

@citizenfx citizenfx deleted a comment from Pundah Feb 19, 2025
@prikolium-cfx
Copy link
Collaborator

What happened?

On the latest gamebuild (3407) some components crash the client

Expected result

It should set the component and not crash

Reproduction steps

SetPedCollectionComponentVariation(PlayerPedId(), 6, "mp_m_2024_02", 4, 0, 0);

Importancy

Crash

Area(s)

FiveM

Specific version(s)

Gamebuild 3407 / Windows b12168

Additional information

No response

You can also help the process by providing a crash dump.

@prikolium-cfx
Copy link
Collaborator

prikolium-cfx commented Feb 19, 2025

Yeah i wouldn't expect cfx to fix this ever tbh lol

Could you please keep any github discussions only engineering and issue related.

@CeebDev
Copy link
Author

CeebDev commented Feb 19, 2025

You can also help the process by providing a crash dump.

Is this real ? Why do i need to provide a crash dump when i give you a 100% repro code ? You can't test and get the dump on your side ??

@CeebDev
Copy link
Author

CeebDev commented Feb 19, 2025

Reported on Dec 29, 2024, ~3 months to let you start the game, execute this code and grab the dump.

And now asking to provide a dump to "help the process" is crazy

@DaniGP17
Copy link
Contributor

dont expect much from the ctrl:v team

I think it would be better to try to collaborate and try to prevent this issue from being blocked and forgotten.

Pattern of the function that crash(b3407): 85 D2 0F 84 ? ? ? ? 48 8B C4 48 89 58 ? 48 89 68 ? 48 89 70 ? 48 89 78 ? 41 56 48 83 EC ? 8D 42
87fd845e-6f90-45a6-927a-2a94101dfdcd.dmp

@citizenfx citizenfx deleted a comment from KillStr3aK Feb 19, 2025
@prikolium-cfx
Copy link
Collaborator

dont expect much from the ctrl:v team

I think it would be better to try to collaborate and try to prevent this issue from being blocked and forgotten.

Pattern of the function that crash(b3407): 85 D2 0F 84 ? ? ? ? 48 8B C4 48 89 58 ? 48 89 68 ? 48 89 70 ? 48 89 78 ? 41 56 48 83 EC ? 8D 42 87fd845e-6f90-45a6-927a-2a94101dfdcd.dmp

Thank you Dani.

@prikolium-cfx
Copy link
Collaborator

dont expect much from the ctrl:v team

I think it would be better to try to collaborate and try to prevent this issue from being blocked and forgotten.

Pattern of the function that crash(b3407): 85 D2 0F 84 ? ? ? ? 48 8B C4 48 89 58 ? 48 89 68 ? 48 89 70 ? 48 89 78 ? 41 56 48 83 EC ? 8D 42 87fd845e-6f90-45a6-927a-2a94101dfdcd.dmp

Fix is ready, waiting for code review. That's how this component will look after the fix:

Image

@DaniGP17
Copy link
Contributor

Yes, I was just told that some DLC clothes are console exclusive and for PC there are placeholder files that for some strange reason were crashing. Can I see the fix you did, just out of curiosity?

@CeebDev
Copy link
Author

CeebDev commented Feb 19, 2025

Yes, I was just told that some DLC clothes are console exclusive and for PC there are placeholder files that for some strange reason were crashing. Can I see the fix you did, just out of curiosity?

It's weird bcs i check for IsPedCollectionComponentVariationGen9Exclusive, also, some of these components are part of outfits and it's returned by the game itself

@prikolium-cfx
Copy link
Collaborator

Yes, I was just told that some DLC clothes are console exclusive and for PC there are placeholder files that for some strange reason were crashing. Can I see the fix you did, just out of curiosity?

It was referring non existing shader variable which most likely exist only in Gen9. So I just simply do not set shader variable if it doesn't exist.

@prikolium-cfx
Copy link
Collaborator

prikolium-cfx commented Feb 19, 2025

Yes, I was just told that some DLC clothes are console exclusive and for PC there are placeholder files that for some strange reason were crashing. Can I see the fix you did, just out of curiosity?

That's how this cool component looks in CodeWalker
Exactly same now as on the screenshot from the game

Image

@prikolium-cfx
Copy link
Collaborator

Yes, I was just told that some DLC clothes are console exclusive and for PC there are placeholder files that for some strange reason were crashing. Can I see the fix you did, just out of curiosity?

d48d5b6

Here is how it looks in code.

@DaniGP17
Copy link
Contributor

d48d5b6

Here is how it looks in code.

Thanks

@whyauthentic
Copy link

Hey, is it already fixed? I'm getting the same issue for all my Players...

@mickeygeecom
Copy link
Contributor

Hey, is it already fixed? I'm getting the same issue for all my Players...

You just answered your own question.

@whyauthentic
Copy link

You just answered your own question.

Yes, but I'm confused by @prikolium-cfx post

@prikolium-cfx
Copy link
Collaborator

You just answered your own question.

Yes, but I'm confused by @prikolium-cfx post

Hi. What exactly confused you? I can explain and add details if you need any

@whyauthentic
Copy link

Hi. What exactly confused you? I can explain and add details if you need any

Yes, uhm you closed the issue and somehow wrote something about fix :D Is the problem fixed now or how does it work?

@prikolium-cfx
Copy link
Collaborator

Hi. What exactly confused you? I can explain and add details if you need any

Yes, uhm you closed the issue and somehow wrote something about fix :D Is the problem fixed now or how does it work?

It's fixed now for clients who use Latest update channel. After some time, when we will see that it's stable and doesn't break anything it will be pushed as a hotfix to beta and production update channels.

@whyauthentic
Copy link

It's fixed now for clients who use Latest update channel. After some time, when we will see that it's stable and doesn't break anything it will be pushed as a hotfix to beta and production update channels.

Okay, so i can say my Players to change to Latest and it should work? Is there anyway we can help with stable testing :D

@prikolium-cfx
Copy link
Collaborator

It's fixed now for clients who use Latest update channel. After some time, when we will see that it's stable and doesn't break anything it will be pushed as a hotfix to beta and production update channels.

Okay, so i can say my Players to change to Latest and it should work? Is there anyway we can help with stable testing :D

You can help for sure, you can ask for example 10 players to test that on Latest and if that's stable for 1-2 hours for them, I will push that to other branches.

@whyauthentic
Copy link

It's fixed now for clients who use Latest update channel. After some time, when we will see that it's stable and doesn't break anything it will be pushed as a hotfix to beta and production update channels.

Okay, so i can say my Players to change to Latest and it should work? Is there anyway we can help with stable testing :D

You can help for sure, you can ask for example 10 players to test that on Latest and if that's stable for 1-2 hours for them, I will push that to other branches.

Okay :) Thank you! Im gonna test it with some of my Players :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash game-bug Bugs that appear to be related to game code.
Projects
None yet
Development

No branches or pull requests