Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical mode #6

Closed
1 of 3 tasks
chris-y opened this issue Jan 18, 2022 · 2 comments
Closed
1 of 3 tasks

Hierarchical mode #6

chris-y opened this issue Jan 18, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@chris-y
Copy link
Owner

chris-y commented Jan 18, 2022

Experimental hierarchical mode has a few known issues:

  • Archive requires entries for directories
  • These directory entries need to be immediately ahead of their contents

Fixes for these:

  • Fake directory entries
    • Attempted this but didn't really work, and definitely would have failed upon encountering a file suddenly two levels deep.
  • Sort archive contents
    • Sort order needs fixing as a normal alphabetical sort (locale/Strncmp) puts dir.info between dir and the contents of dir (resulting in dir which is expandable but has no contents, and the contents either hidden or in a disconnected leaf state)
  • xad v12 does not mark some directories as directories, instead they are files ending in '/'
    • I did fix this but have disabled it as it was causing other problems when I was testing under xad v13.
@chris-y chris-y added bug Something isn't working help wanted Extra attention is needed labels Jan 18, 2022
@chris-y chris-y pinned this issue Jan 19, 2022
chris-y added a commit that referenced this issue Jan 20, 2022
@chris-y
Copy link
Owner Author

chris-y commented Jan 20, 2022

Previous commit attempts to sort '/' above all other characters, although I'm getting entries randomly sorted into the wrong places, so there is a bug in this function (beyond one I've already fixed).

chris-y added a commit that referenced this issue Jan 20, 2022
@chris-y chris-y added the enhancement New feature or request label Jul 2, 2022
@chris-y
Copy link
Owner Author

chris-y commented Aug 11, 2022

Rethinking this. Might be better to scan the entire archive and work out the directory structure, rather than expecting the files to be in a sensible order. This will pick up when folders are implied.

Scan
Create directory structure including files <-- this is the stage we're missing
Move directory structure into list view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant