-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add formatting to numbers output by bi_class_breaks() #35
Comments
If you like my idea, I offer to attempt the addition of this SI_lab parameter to bi_class_breaks() |
thanks for the suggestion @RickPack! I'd love to add a formatting argument for |
@chris-prener, I'll give it a try in the next few days! |
Can you assign this to me? |
I will get to this soon, @chris-prener, hopefully later today. |
No rush @RickPack! |
Working on this now! |
@chris-prener, can you help me understand the need for as.numeric under the split == TRUE condition in https://github.com/chris-prener/biscale/blob/main/R/bi_class.R? My use of the SI prefix is causing an error (e.g., 323k instead of 323001). |
@chris-prener also noting your title at https://chris-prener.github.io/biscale/articles/biscale.html has "Bivarite" |
Along with the "Bivarite" misspelling, also need a library(ggplot2) somewhere before the ggplot() at https://chris-prener.github.io/biscale/articles/biscale.html. |
I'm going to leave this open just so that I can iron out some documentation for how this works, @RickPack - will ask you to take a look at that when it is done! |
@chris-prener, will do and unfortunately, my technique occasionally does not work properly. I am on the run but will get you an example and hopefully a solution as soon as I can. It generally works though. |
Hi there! Been following this thread closely and excited you've been working on some formatting for the bi_class_breaks() labels. I wanted to see if there is any update or if this has been added to the newest version or if there's plans to released it yet? Thanks so much! |
Hi @quintercept this is still in process! |
@quintercept , you or another can edit my pull request if you like? I am not sure when I will get to this. Along with fixing the issue above, I would like to experiment with either |
Might you enable the passing of functions to bi_class_breaks() to format numbers?
Or, for my particular interest, you could add an
SI_lab
(International System of Units) parameter that would passdigits
to thesi_number
function in my code below.This reduction of text for large numbers makes it easier to increase the font size and position the legend.
Currently
With proposed SI_lab parameter
Using

SI_lab(3)
Code to aid addition of SI_lab parameter
First, create
miami_rent_income
object using my code at https://stackoverflow.com/a/72591940/2305061.Then, focusing on modification to labels1.
The text was updated successfully, but these errors were encountered: