Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A node that does not need upgrading, but that is upgradable, does not get provisioned #188

Open
ripienaar opened this issue Feb 22, 2023 · 0 comments
Open

A node that does not need upgrading, but that is upgradable, does not get provisioned #188

ripienaar opened this issue Feb 22, 2023 · 0 comments

Comments

@ripienaar
Copy link
Member

In the scenario where a node is upgradable, the helper says upgrade and the node is already at the right version, provisioning does not continue.

provisioner/host/host.go

Line 184 in 7c408c7

err := h.handleHostUpgrade(ctx)

This method returns nil for no error and also nil for skipped due to version constraint, we should make it return an additional skipped bool.
ripienaar added a commit to ripienaar/provisioner that referenced this issue Feb 22, 2023
@ripienaar
(choria-io#188) adds a skip indicator for version upgrade skips
a1351bd 
Signed-off-by: R.I.Pienaar <[email protected]>
ploubser added a commit that referenced this issue Feb 23, 2023
@ploubser
Merge pull request #189 from ripienaar/188
0cf791d 
(#188) adds a skip indicator for version upgrade skips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ripienaar