Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individually package the adapters #18

Open
bcomnes opened this issue Feb 12, 2018 · 6 comments
Open

Individually package the adapters #18

bcomnes opened this issue Feb 12, 2018 · 6 comments

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Feb 12, 2018

It was pointed out in #6 (comment) by @alterx that some of these adapters might require heavy dependencies or peer deps. Rather than bundle all those together, we should make each adapter its own repo/module so that people dont have to feel the weight of every adapter.

So... for anyone interested, redo the adapters you are interested in maintaining as a module and we can remove it from this repo, but still reference/export it as a collection since we already have this.

@yoshuawuyts
Copy link
Member

Aye, this sounds great!

@kareniel
Copy link
Member

kareniel commented Feb 12, 2018

I have a repo for an angular.js 1.x adapter over here.
How did you imagine the exports from this module would work? Kind of like choo does with bel?

@bcomnes
Copy link
Contributor Author

bcomnes commented Feb 12, 2018

I would model it after https://github.com/maxogden/mississippi

@emkay
Copy link

emkay commented Jun 6, 2018

I wanted to use nanocomponent-adapters to prototype some components at work, which is primarily an Angular shop and noticed that version 3.0.0 had an empty index.js file in there. Anyways, to test this out I published the angular one as a separate package and saw this issue. Need to fill out README, etc. Happy to add everyone to the repo and give publish access. y'all just ping me if you want it.

https://github.com/emkay/nanocomponent-adapters-angular
https://www.npmjs.com/package/nanocomponent-adapters-angular

@bcomnes
Copy link
Contributor Author

bcomnes commented Jun 6, 2018

Looks awesome, we should point to it from here.

@emkay
Copy link

emkay commented Jun 6, 2018

#20 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants