-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choo 6 release candidate feedback #519
Comments
Ok, maybe a lil more:
|
This was referenced Jun 28, 2017
Implemented the link handling here choojs/nanohref#6 |
Merged
Any chance for out-of-the-box ssr with bankai for 6? |
Already works out of the box! 🎉 although I haven't had time to polish the
implementation haha; patches are def welcome!
https://github.com/yoshuawuyts/choo-reload
…On Tue, Jul 4, 2017 at 12:41 AM Seth Thompson ***@***.***> wrote:
Any chance for out-of-the-box ssr with bankai for 6?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#519 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWlemM9GUsgaPyT1m0aAYWA3c05NUSXks5sKW4agaJpZM4OH_1P>
.
|
Oh lol, SSR !== server side reload haha. Oops, bit sleepy - yeah, planning
to add that to the next release of bankai; whipped up a patch today, and
just want to add ciritical path CSS inlining too and we should be good to
go. edit: put out a PR choojs/bankai#212
|
Choo 6 is very released! Ok to close this? |
@ungoldman ah yeah, good one! Feel free to just close issues like these if you spot them 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is an aggregate issue for feedback on the Choo 6 RC. The release is complete feature-wise, but there might be bugs. Let us know what's going wrong (or going very right) and we'll be happy to help out. Cheers!
Todos
'*'
routes insteadstate.query
data-no-routing
attribute and check other hosts +target="noopener"
links insteadyo-yoify
add whitespace collapse for bel 5 parity shama/yo-yoify#49pelo
Clean up whitespace shuhei/pelo#7yo-yoify
bel
to newpelo
(fixes test failures in choo)Known issues
None so far
See Also
The text was updated successfully, but these errors were encountered: