You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.
I'd recommend that for description and releaseNotes, adopt the following approach:
Ignore any URLs that are inside code blocks
Ignore any URLs that are not within a MarkDown hyperlink
For any remaining URLs that are found to be invalid, just raise a warning (instead of a failing error) and display the actual URL in question (to help package maintainers figure out if there's a real problem they can fix or not)
For releaseNotes, while this element can contain any text, some packages do just put a single URL as the content. In that specific case, I think it would be reasonable to apply the strict failing validation to the URL, but for all other content in releaseNotes then apply the same rules above as for description
The text was updated successfully, but these errors were encountered:
@flcdrg I think that there is still work to be done on this issue to account for everything, but the package that you specifically mention in the issue has now successfully passed validation.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The new URL validation is a little too strict for
description
andreleaseNotes
fields.For example, https://chocolatey.org/packages/azure-pipelines-agent/2.163.1 now fails, presumably because 'example' URLs are used in the description.
I'd recommend that for
description
andreleaseNotes
, adopt the following approach:For
releaseNotes
, while this element can contain any text, some packages do just put a single URL as the content. In that specific case, I think it would be reasonable to apply the strict failing validation to the URL, but for all other content inreleaseNotes
then apply the same rules above as fordescription
The text was updated successfully, but these errors were encountered: