Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In projects list, when no website link is added (e.g. "N/A" is used), this is just taken as if it was a link #48

Open
mgielda opened this issue Mar 30, 2023 · 3 comments
Open

In projects list, when no website link is added (e.g. "N/A" is used), this is just taken as if it was a link #48

mgielda opened this issue Mar 30, 2023 · 3 comments
Assignees
@cjyabraham

Comments

@mgielda
Copy link
Member

mgielda commented Mar 30, 2023

The correct behavior should be to check if this is a link and if not, do not make a link (and hide the "website link" column.

Checking if a value is a link should be fairly trivial, I assume.
@cjyabraham
Copy link
Collaborator

findRE should work to test whether the entry is a link

@mgielda
Copy link
Member Author

mgielda commented May 4, 2023

Hi @cjyabraham could you help fix this?

@cjyabraham cjyabraham mentioned this issue May 5, 2023
Closed
@cjyabraham cjyabraham self-assigned this May 5, 2023
@cjyabraham
Copy link
Collaborator

PR ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjyabraham cjyabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test to see if a url is provided for project website chipsalliance/chips-alliance-website
2 participants
@mgielda @cjyabraham