Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management FLOAT & INT value #11

Open
15 tasks done
cobalt74 opened this issue Nov 4, 2013 · 12 comments
Open
15 tasks done

Management FLOAT & INT value #11

cobalt74 opened this issue Nov 4, 2013 · 12 comments
Assignees
@cobalt74
Labels
bug enhancement

Comments

@cobalt74
Copy link
Collaborator

cobalt74 commented Nov 4, 2013

  • Add constant FLOAT (NUMERIC) & INT
  • Display cell value - Localisation decimal symbol
  • Display cell value - Localisation thousands separator
  • Recover cell value - Localisation decimal symbol
  • Edit Cell value - Localisation decimal symbol
  • Search value - Localisation decimal symbol
  • QuickSearch value - Localisation decimal symbol
  • Making selectable number of decimal for display
  • Add text in json
  • Edit line recover value - Localisation decimal symbol
  • Error message for edit cell (INT, FLOAT)
  • For all update mode : Replace localized thousand symbol by nothing

changes related

  • Update column of lisha_language (varchar(1)) for accept space char

Bugs

  • Not Display 0,00 when value is null
  • Refresh lost float specifique lisha configuration
@ghost ghost assigned cobalt74 Nov 4, 2013
cobalt74 referenced this issue Nov 4, 2013
@cobalt74
Gestion des types __FLOAT__(__NUMERIC__), __INT___
2924bdd 
Gestion du format de localisation.
- Affichage des séparateurs de millier + symbole de décimal
- Insertion, modification sur cellule
Correction bug sur message d'erreur : les input sans règles (!= requis, != interdit) sont bloqués pour l'insertion suite à une erreur de saisie dans le formulaire.

Il faut deux textes 156, 157 pour la gestion des erreurs de saisie des INT et FLOAT
<code>
(156, 'ENG', '', 'Value <b>$value</b> of <b>$name</b> is not an integer value!!', 'lisha1.00'),
(156, 'FRA', '', 'La valeur <b>$value</b> de <b>$name</b> n''est pas un entier', 'lisha1.00'),
(157, 'ENG', '', 'Value <b>$value</b> of <b>$name</b> is not a float value!!', 'lisha1.00'),
(157, 'FRA', '', 'La valeur <b>$value</b> de <b>$name</b> n''est pas un décimal', 'lisha1.00');
</code>

Pour le séparateur de millier, il faut changer le type de la colonne en bdd (char(1) n'enregistre pas les espaces)
<code>
ALTER TABLE  `lisha_language` CHANGE  `thousand_symbol`  `thousand_symbol` VARCHAR( 1 ) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL COMMENT  'Thousand digit'
</code>
@chezbas
Copy link
Owner

chezbas commented Nov 5, 2013

Update cell mode doesn't check control on INT type

Unit test case:
Define a column with INT feature
add a new row ( control ok )
Try to update straight on cell ==> update done
Expected results : Error message

cobalt74 added a commit that referenced this issue Nov 5, 2013
@cobalt74
#11
6fb4098 
- Making selectable number of decimal for display
- Not Display 0,00 when value is null
other
- finish lisha text migration (include MT / Doc)
@cobalt74
Copy link
Collaborator Author

cobalt74 commented Nov 5, 2013

@chezbas est ce que tu peux ajouter à la table lisha_language

  • le champ : number_of_decimal INT(2) - défaut 2 ?

@chezbas
Copy link
Owner

chezbas commented Nov 6, 2013

Ok, c’est fait
J’ai supprimé la table lisha_text et activé l'utilisation des fichiers xxx.json
j’ai renommé la table lisha_language en lisha_i18n
Bref..
have fun
Le 5 nov. 2013 à 22:40, Cobalt74 [email protected] a écrit :

@chezbas est ce que tu peux ajouter à la table lisha_language

le champ : number_of_decimal INT(2) ?
—
Reply to this email directly or view it on GitHub.

@cobalt74
Copy link
Collaborator Author

cobalt74 commented Nov 6, 2013

Pour récapituler, il faut :

  • changer les main_configuration.php de tous les projets
define("__LISHA_TABLE_LOCALIZATION__","lisha_i18n");    // Localization information

Pour le raccourcis de la doc ?

cobalt74 added a commit that referenced this issue Nov 6, 2013
@cobalt74
#11 correction bug perte de la config number_of_decimal sur reset
19bc277
cobalt74 added a commit that referenced this issue Nov 6, 2013
@cobalt74
Revert "uncommit change #11"
7fa5cba 
This reverts commit 7fb0f5cc4e057932ca4326143672abc44b52f8c2.
cobalt74 added a commit that referenced this issue Nov 6, 2013
@cobalt74
#11 correction d’édit lines pour prise en compte du symbole decimal
99bbc45 
RAF : affichage de la virgule de decimal sur la récupération des valeurs dans les inputbox de modification
@chezbas
Copy link
Owner

chezbas commented Nov 7, 2013

Cell update
Test case :
On a FLOAT column type
$obj_lisha_tran>define_column("transaction.my_numeric",'my_numeric','MyNum',FLOAT,WRAP,LEFT);
$obj_lisha_tran->define_attribute('__column_number_of_decimal', 7,'my_numeric');

Input value "123" and validate
Input value "a" straight in cell and validate

Result recorded is 0

Expected results : Error message as in line update that said : You have to input a numeric value !!
Escape key exit cells update mode and return to display

@chezbas
Copy link
Owner

chezbas commented Nov 7, 2013

Have to enable NULL feature on numeric column if you want to display blank

@chezbas
Copy link
Owner

chezbas commented Nov 7, 2013

Row update
input NULL value rise a unexpected message error
error_message_to_fix

cobalt74 added a commit that referenced this issue Nov 7, 2013
@cobalt74
#11 suite
d404a0b 
- quelques correction sur les float et int (required ou non)
- ajout des messages d’erreurs en cas de int ou float invalide sur l’edit cell. (retour message d’erreur)
cobalt74 added a commit that referenced this issue Nov 7, 2013
@cobalt74
#11 bug null value ne fonctionnait plus :) sur les champs int float n…
17c85a7 
…on obligatoire
cobalt74 added a commit that referenced this issue Nov 8, 2013
@cobalt74
#11 suite thousand symbol for Int. edit cell / error message
f3962ff
@chezbas
Copy link
Owner

chezbas commented Nov 11, 2013

Display bug:
Test case on e
dit line mode :
choose a line with decimal value
data recover in input field is not localized
Here below an example
delta

@cobalt74
Copy link
Collaborator Author

ouep je sais !! :)
il reste ça : Edit line recover value - Localisation decimal symbol

cobalt74 added a commit that referenced this issue Nov 11, 2013
@cobalt74
#11 last dev (Edit line recover value - Localisation decimal symbol)
d2eba59
@cobalt74
Copy link
Collaborator Author

faudra faire des fonctions dans chaque classe BDD pour être plus propre.

@chezbas
Copy link
Owner

chezbas commented Nov 12, 2013

Yes sir,
A clean pass to do for a lot of things ;)

@chezbas
Copy link
Owner

chezbas commented Nov 14, 2013

Have a bug

Test case
Edit line mode with numeric column
capture decran 2013-11-14 a 06 17 31
Clear content and check update box
capture decran 2013-11-14 a 06 17 41
Press enter to record modification rise an error
capture decran 2013-11-14 a 06 17 09

Error_log file side rise a notice on query error
UPDATE transaction SET my_numeric =
WHERE (index = "3")

@chezbas chezbas reopened this Nov 14, 2013
chezbas added a commit that referenced this issue Nov 14, 2013
@chezbas
Bug fix when we try to erase a numeric column type using full line ed…
0623521 
…ition mode

Github #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cobalt74 cobalt74

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cobalt74 @chezbas