-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release on Node12 #133
Comments
@jjrv Any timeline here? It is slowly becoming a problem to not support nodejs12 for software relying on nbind. |
If anyone is interested, we've published a fork: We needed it for node 12 migration, so we just forked the module as is (plus a minor TS fix) and changed the name - works great. The fork: https://github.com/mceSystems/nbind |
@mceIdo Thank you very much |
@jjrv Also, if you have abandoned the maintenance of this repo. this would be really benefit to have a notice. |
@jjrv I would also be very interested if there is any maintenance/development ongoing. |
@mceldo We still don't have checked with your fork |
@kelson42, to be honest, given the awesome work done on N-API and the complementary node-addon-api for c++, next time I'll develop a new native module, or have a major refractor in one of my existing ones - I'll probably move to N-API based implementation |
I was forced to go with embind directly. And work around the deficiencies it has. |
It's broken with node >= v13 or electron >= 8 which use (node v12 but) a newer version of v8 (like node v13) |
MWOffliner would love to have a node 12 release (openzim/mwoffliner#707)
This merged pr: #130 gets node 12 support working, but I think we still need to update the emscripten code.
The text was updated successfully, but these errors were encountered: