Added borderDash support for grid lines (#3136) #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a problem with this change. If the borderDash property is set for grid lines, it affects the point borders in the line graph too. Checking this out. |
|
Works after restoring the context once the line is drawn. Pardon my unfamiliarity with canvas drawing. Requesting a review. |
| context.lineWidth = itemToDraw.glWidth; | ||
| context.strokeStyle = itemToDraw.glColor; | ||
| if (itemToDraw.glBorderDash) { |
There was a problem hiding this comment.
this check should also check for the existence of context.setLineDash. On IE 9 and 10 this does not exist.
|
Thanks @karthikiyengar |
|
👍 |
|
Looks good, +1 |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* Added borderDash support for grid lines (chartjs#3136) * Save and restore context to prevent border dash being applied to other elements * Adds support for borderDashOffset, checks for setLineDash (IE9/IE10) * Fixes tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if anything else is necessary here and I shall be happy to look into it.