From 1e933dc24367bc69837fb8aa8c9b366aa5f0a342 Mon Sep 17 00:00:00 2001 From: Charlie Vieth Date: Thu, 25 May 2023 01:13:49 -0400 Subject: [PATCH] Makefile: cleanup test targets and comment --- Makefile | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index df7c6b7..6ec3877 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,8 @@ MAKEFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST))) MAKEFILE_DIR := $(dir $(MAKEFILE_PATH)) +# TODO: include internal/benchtest Makefile + # Test options GO ?= go GOBIN ?= $(MAKEFILE_DIR)/bin @@ -47,8 +49,10 @@ yellow = $(shell { tput setaf 3 || tput AF 3; } 2>/dev/null) cyan = $(shell { tput setaf 6 || tput AF 6; } 2>/dev/null) term-reset = $(shell { tput sgr0 || tput me; } 2>/dev/null) +# Run tests and linters. If this passes then CI tests +# should also pass. .PHONY: all -all: test install +all: install test vet golangci-lint testgenerate # Install pre-commit hooks and download modules .PHONY: install @@ -56,6 +60,8 @@ install: pre-commit @go mod download @go install +# TODO: I don't think we need/want override here + # Run verbose tests testverbose: override GO_TEST_FLAGS += -v @@ -98,7 +104,7 @@ testgenerate: bin/gen # Run all tests (slow) .PHONY: testall -testall: exhaustive testskipped testgenerate calibrate +testall: exhaustive testskipped testgenerate # Install richgo bin/richgo: