From 762eec682450a6631342fad06898471ea2a6aa90 Mon Sep 17 00:00:00 2001
From: tserg <8017125+tserg@users.noreply.github.com>
Date: Tue, 21 Jan 2025 12:17:56 +0800
Subject: [PATCH] chore[ci]: improve coverage jobs (#4457)

This commit makes minor improvements to the coverage CI:
1. Consolidate upload of coverage artifacts into a single step
2. Change `file` field to `files` for `codecov-action@v5`

references:
- https://github.com/codecov/codecov-action?tab=readme-ov-file#migration-guide

---------

Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
---
 .github/workflows/test.yml | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index d4bfc2ee9c..8492fb25aa 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -271,20 +271,16 @@ jobs:
       run: |
         coverage xml
 
-    - name: Upload coverage sqlite artifact
+    - name: Upload coverage artifacts
       # upload coverage sqlite db for debugging
+      # upload coverage.xml artifact for downstream codecov upload action
       uses: actions/upload-artifact@v4
       with:
-        name: coverage-sqlite
+        name: coverage-artifacts
         include-hidden-files: true
-        path: .coverage
-        if-no-files-found: error
-
-    - name: Upload coverage.xml
-      uses: actions/upload-artifact@v4
-      with:
-        name: coverage-xml
-        path: coverage.xml
+        path: |
+          .coverage
+          coverage.xml
         if-no-files-found: error
 
   upload-coverage:
@@ -296,10 +292,10 @@ jobs:
     - uses: actions/checkout@v4
     - uses: actions/download-artifact@v4
       with:
-        name: coverage-xml
+        name: coverage-artifacts
 
     - name: Upload Coverage
       uses: codecov/codecov-action@v5
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
-        file: coverage.xml
+        files: coverage.xml