Simplify generatorConfigs.yaml #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add enabled_scripts for every script of Generator Take the sections from Excel and not from generatorConfigs.yaml Remove any useless variables from generatorConfigs.yaml Use a survey_folder_path to keep the generator survey consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Justification
Sometimes, we don't want to use every script from Generator for a specific survey.
Also, it's going to be way easier to configs for the new user working with Generator.
Description
Add enabled_scripts for every script of Generator
Take the sections from Excel and not from generatorConfigs.yaml
Remove any useless variables from generatorConfigs.yaml
Use a survey_folder_path to keep the generator survey consistent
After
Before
I can't even take a screenshot of the old configs, because it's too long (51 lines vs 13 lines).
