Add new input types for Evolution-Generator #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahini
reviewed
Mar 27, 2024
samuel-duhaime
force-pushed
the
addNewInputTypesForGenerator
branch
2 times, most recently
from
7ff5641 to
4764617
Compare
tahini
requested changes
Mar 27, 2024
| @@ -8,6 +8,7 @@ | |||
| // Note: This file includes types for all the different input and widgets types used in the evolution-generator | |||
|
|
|||
| import { TFunction } from 'i18next'; | |||
| // import { IconDefinition } from '@fortawesome/fontawesome-common-types'; | |||
There was a problem hiding this comment.
Pourquoi garder cet import commenté? il faudrait l'enlever? Surtout que c'est IconDefinition dans les 2 cas, de 2 endroits semi-différents...
There was a problem hiding this comment.
C'est fait.
|
L'impact est pas trop important sur les enquêtes générées? |
Add new input types for Evolution-Generator Remove optional interview and path on input types for function
samuel-duhaime
force-pushed
the
addNewInputTypesForGenerator
branch
from
4764617 to
59cffd1
Compare
J'ai réussi à compiler l'enquête que je travaille sans problèmes. Il va sûrement avoir quelques changements à faire pour d'autres enquêtes, mais ça devrait être assez simple à implémenter. |
tahini
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Add new input types for the Evolution-Generator
Remove optional interview and path on input types for function