Add car and householdSize validations #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add car and householdSize validations Add defaultValue type Get better types in inputTypes.ts
samuel-duhaime
force-pushed
the
addCarAndHouseholdSizeValidations
branch
from
99c9580 to
54b0237
Compare
tahini
approved these changes
Mar 25, 2024
| return [ | ||
| { | ||
| validation: isNaN(Number(value)) || !Number.isInteger(Number(value)), | ||
| errorMessage: { |
There was a problem hiding this comment.
Il faudrait à terme s'orienter vers des messages seulement via des fichiers de locales. Pas nécessairement maintenant, mais tranquillement.
There was a problem hiding this comment.
Oui, en effet @tahini.
Est-ce qu'il y a un avantage d'utiliser les fichiers de locales comparativement à cette méthode ?
There was a problem hiding this comment.
Est-ce qu'il y a un avantage d'utiliser les fichiers de locales comparativement à cette méthode ?
Plusieurs:
- Les messages sont tous rassemblés au même endroit, ce qui facilite leur édition plutôt que perdu un peu partout dans le code
- C'est assez simple et trivial d'ajouter des langues en traduisant uniquement ces fichiers
- Question responsabilité, un fichier de code ne devrait pas aussi contenir des traductions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Add car and householdSize validations
Add defaultValue type
Justification
We are using some validations in many surveys.