Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange commitment bug happened on December 13, 2024 #1720

Open
ercecan opened this issue Jan 20, 2025 · 1 comment
Open

Strange commitment bug happened on December 13, 2024 #1720

ercecan opened this issue Jan 20, 2025 · 1 comment

Comments

@ercecan
Copy link
Member

ercecan commented Jan 20, 2025

Summary

On December 13, 2024, Testnet4 experienced a reorg larger than our expected maximum finality depth. That caused a lot of problems so we had to use a snapshot of the sequencer state to get the state from one hour before the incident and continue working on that. However before we did that sequencer had already sent some commitments that are now invalid because with the new state there are other commitments with same l2 ranges that overrule them.

These overruled l1 blocks are: [57775, 57777, 57778, 57786, 57804, 57805]

Interestingly I noticed that the sequencer commitment in the block 57805 has an l2 range starting from 1 ending at 1000, while other commitment ranges are somewhere around 3_000_000.
This should not have happened at all and warrants further investigation

@eyusufatik
Copy link
Member

Good catch 👍

In our new sequencer commitment -> batch proof -> light client proof design we should look out for cases like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants