TODOs tracking issue

[rakanalh]

This issue tracks all TODOs in the codebase for further investigation and decision making. However, the following list excludes:

• Test TODOs
• Sov-SDK TODOs

Rollup

• Placeholder for issue
  

  citrea/bin/citrea/src/rollup/mod.rs

  Lines 59 to 61 in a6f1edd

  	// TODO: Double check what kind of storage needed here.
  	// Maybe whole "prev_root" can be initialized inside runner
  	// Getting block here, so prover_service doesn't have to be `Send`

It seems to me that the ProverService trait does not enforce Send. More context is needed here.

• Placeholder for issue
  

  citrea/bin/citrea/src/rollup/mod.rs

  Line 88 in a6f1edd

  // TODO(https://github.com/Sovereign-Labs/sovereign-sdk/issues/1218)

This points to an issue Sovereign-Labs/sovereign-sdk#1218

• Placeholder for issue
  

  citrea/Cargo.toml

  Lines 56 to 58 in a6f1edd

  	# TODO: Consider replacing this serialization format
  	# https://github.com/Sovereign-Labs/sovereign-sdk/issues/283
  	bincode = "1.3.3"

Risc0 crate

• New risc0 api recover #1410
  

  citrea/crates/risc0/src/host.rs

  Lines 169 to 174 in a6f1edd

  	fn recover_proving_sessions(&self) -> Result<Vec<Proof>, anyhow::Error> {
  	Ok(Vec::new())
  	// TODO: fix this https://github.com/chainwayxyz/citrea/issues/1410
  	//
  	// let sessions = self.ledger_db.get_pending_proving_sessions()?;

Bitcoin-DA crate

• Placeholder for issue
  

  citrea/crates/bitcoin-da/src/helpers/builders/mod.rs

  Lines 357 to 360 in a6f1edd

  	// TODO: adjust size of sig. for different types of addresses
  	for i in 0..tx.input.len() {
  	tx.input[i].witness.push([0; SCHNORR_SIGNATURE_SIZE]);
  	}

• Placeholder for issue
  

  citrea/crates/bitcoin-da/src/fee.rs

  Lines 142 to 144 in a6f1edd

  	MonitoredTxKind::Cpfp => {}
  	_ => bail!("RBF only supported on cpfp TX"), // TODO Add support for bumping reveal TX
  	}

EVM crate

• Placeholder for issue
  

  citrea/crates/evm/src/evm/db.rs

  Lines 110 to 111 in a6f1edd

  	fn code_by_hash(&mut self, code_hash: B256) -> Result<Bytecode, Self::Error> {
  	// TODO move to new_raw_with_hash for better performance

• Placeholder for issue
  

  citrea/crates/evm/src/rpc_helpers/filter.rs

  Lines 648 to 649 in a6f1edd

  	/// TODO: docs + discuss finalized, safe and pending
  	pub fn convert_block_number(

• Placeholder for issue
  

  citrea/crates/evm/src/rpc_helpers/filter.rs

  Lines 659 to 662 in a6f1edd

  	// TODO: Is there a better way to handle this instead of giving the latest block?
  	BlockNumberOrTag::Finalized => start_block,
  	// TODO: Is there a better way to handle this instead of giving the latest block?
  	BlockNumberOrTag::Safe => start_block,

• Placeholder for issue
  

  citrea/crates/evm/src/evm/handler.rs

  Lines 367 to 368 in a6f1edd

  	// TODO check: Nonce for CREATE will be bumped in `handle_create`.
  	if context.evm.env.tx.transact_to.is_call() {

• Placeholder for issue
  

  citrea/crates/evm/src/query.rs

  Lines 880 to 885 in a6f1edd

  	// TODO: this assumes all blocks have the same gas limit
  	// if gas limit ever changes this should be updated
  	let last_block = self
  	.blocks
  	.last(&mut working_set.accessory_state())
  	.expect("Head block must be set");

• Placeholder for issue
  

  citrea/crates/evm/src/query.rs

  Lines 1320 to 1322 in a6f1edd

  	// EvmDB is the replacement of revm::CacheDB because cachedb requires immutable state
  	// TODO: Move to CacheDB once immutable state is implemented
  	let mut evm_db = self.get_db(working_set, current_spec);

• Placeholder for issue
  

  citrea/crates/evm/src/query.rs

  Lines 1324 to 1326 in a6f1edd

  	// TODO: Convert below steps to blocking task like in reth after implementing the semaphores
  	let mut traces = Vec::new();
  	let mut transactions = block_txs.into_iter().enumerate().peekable();

• Placeholder for issue
  

  citrea/crates/evm/src/query.rs

  Lines 1494 to 1496 in a6f1edd

  	// TODO: Understand how to handle this
  	// TAG - true when the log was removed, due to a chain reorganization. false if its a valid log.
  	let removed = false;

• EVM: implement MuxTracer #251
  

  citrea/crates/evm/src/rpc_helpers/tracing_utils.rs

  Lines 86 to 87 in a6f1edd

  	// TODO: either implement or return unsupported
  	GethDebugBuiltInTracerType::MuxTracer => Err(EthApiError::Unsupported("MuxTracer")),

• Placeholder for issue
  

  citrea/crates/evm/src/genesis.rs

  Lines 161 to 162 in a6f1edd

  	// TODO: maybe be able to genesis with Fork1
  	pub(crate) fn init_module(

• Placeholder for issue
  

  citrea/crates/evm/src/genesis.rs

  Lines 243 to 244 in a6f1edd

  	// TODO: Check this for genesis hash - is it completely fine?
  	l1_hash: B256::default(),

• Placeholder for issue
  

  citrea/crates/evm/src/evm/call.rs

  Lines 261 to 262 in a6f1edd

  	// TODO: write hardhat and unit tests for this
  	if request.max_fee_per_gas == Some(0) {

Sequencer

• Placeholder for issue
  

  citrea/crates/sequencer/src/mempool.rs

  Lines 87 to 92 in a6f1edd

  	let validator = TransactionValidationTaskExecutor::eth_builder(Arc::new(chain_spec))
  	.no_cancun()
  	.no_eip4844()
  	// TODO: if we ever increase block gas limits, we need to pull this from
  	// somewhere else
  	.set_block_gas_limit(evm_config.block_gas_limit)

• Placeholder for issue
  

  citrea/crates/sequencer/src/runner.rs

  Lines 511 to 512 in a6f1edd

  	// TODO: handle this error
  	.expect("dry_run_transactions should have already checked this");

• Placeholder for issue
  

  citrea/crates/sequencer/src/runner.rs

  Lines 567 to 571 in a6f1edd

  	// TODO: this will only work for mock da
  	// when https://github.com/Sovereign-Labs/sovereign-sdk/issues/1218
  	// is merged, rpc will access up to date storage then we won't need to finalize rigth away.
  	// however we need much better DA + finalization logic here
  	self.storage_manager.finalize_l2(l2_height)?;

Also related to Sovereign-Labs/sovereign-sdk#1218

• Placeholder for issue
  

  citrea/crates/sequencer/src/runner.rs

  Lines 646 to 650 in a6f1edd

  	// TODO: hotfix for mock da
  	self.da_service
  	.get_block_at(1)
  	.await
  	.map_err(|e| anyhow!(e))?;

• Placeholder for issue
  

  citrea/crates/sequencer/src/runner.rs

  Lines 839 to 841 in a6f1edd

  	let nonce = self.get_nonce(working_set)?;
  	// TODO: figure out what to do with sov-tx fields
  	// chain id gas tip and gas limit

• Placeholder for issue
  

  citrea/crates/sequencer/src/runner.rs

  Lines 856 to 857 in a6f1edd

  	// TODO: figure out what to do with sov-tx fields
  	// chain id gas tip and gas limit

• Placeholder for issue
  

  citrea/crates/sequencer/src/runner.rs

  Lines 892 to 896 in a6f1edd

  	/// Old version of sign_soft_confirmation_batch
  	/// TODO: Remove derive(BorshSerialize) for UnsignedSoftConfirmation
  	/// when removing this fn
  	/// FIXME: ^
  	fn pre_fork1_sign_soft_confirmation_batch<'txs>(

Guests

• Placeholder for issue
  

  citrea/guests/risc0/light-client-proof/bitcoin/src/bin/light_client_proof_bitcoin.rs

  Lines 23 to 25 in a6f1edd

  	Network::Mainnet => "0000000000000000000000000000000000000000000000000000000000000000",
  	// TODO: Update this after finding out the first batch prover output of the next release
  	Network::Testnet => "05183faf24857f0fa6d4a7738fe5ef14b7ebe88be0f66e6f87f461485554d531",

• Placeholder for issue
  

  citrea/guests/risc0/light-client-proof/bitcoin/src/bin/light_client_proof_bitcoin.rs

  Lines 49 to 50 in a6f1edd

  	// TODO: Update
  	Network::Mainnet => &[(0, [0; 8])],

• Placeholder for issue
  

  citrea/guests/risc0/light-client-proof/bitcoin/src/bin/light_client_proof_bitcoin.rs

  Lines 65 to 66 in a6f1edd

  	// TODO: Update
  	Network::Devnet => &[(0, [0; 8])],

(these three will be handled while releasing Fork1 for devnet and testnet, let them stay thoug no need for issues)