Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto urlize links in articles. #15

Open
hobeone opened this issue May 26, 2013 · 6 comments
Open

Auto urlize links in articles. #15

hobeone opened this issue May 26, 2013 · 6 comments

Comments

@hobeone
Copy link

hobeone commented May 26, 2013

I subscribe to a few twitter feeds through their api:
http://api.twitter.com/1/statuses/user_timeline.rss?screen_name=XXXXX

It's common for some people to have a short status + a link to a photo on facebook or flickr. They aren't full HTML links though just text of the url. It would be nice to automatically turn them into clickable links in the DDD ui.

Here's an example feed:
http://api.twitter.com/1/statuses/user_timeline.rss?screen_name=ArgonautCycles

@cgrinds
Copy link
Owner

cgrinds commented May 26, 2013

I looked at this and the tt-rss server does this currently.
However, the server only changes text links to urls when santizie=true. I could add the functionality client-side but not sure that makes sense. Any thoughts?

@cgrinds
Copy link
Owner

cgrinds commented May 26, 2013

I have a working version in the linkify branch. Check it out and let me know what you think.

My only concern is performance since it will be applied indiscriminately to all article content but that's just a gut feeling I haven't profiled anything yet.

@cgrinds
Copy link
Owner

cgrinds commented May 26, 2013

I have a working version in the linkify branch if you want to check it
out.

-Chris

On 05/26, hobeone wrote:

I subscribe to a few twitter feeds through their api:
http://api.twitter.com/1/statuses/user_timeline.rss?screen_name=XXXXX

It's common for some people to have a short status + a link to a photo on facebook or flickr. They aren't full HTML links though just text of the url. It would be nice to automatically turn them into clickable links in the DDD ui.

Here's an example feed:
http://api.twitter.com/1/statuses/user_timeline.rss?screen_name=ArgonautCycles


Reply to this email directly or view it on GitHub:
#15

Chris Grindstaff | http://gstaff.org

@hobeone
Copy link
Author

hobeone commented May 27, 2013

I think you need to checkin linkify.js too?

On Sun, May 26, 2013 at 4:16 PM, Chris Grindstaff
[email protected]:

I have a working version in the linkify branch if you want to check it
out.

-Chris

On 05/26, hobeone wrote:

I subscribe to a few twitter feeds through their api:
http://api.twitter.com/1/statuses/user_timeline.rss?screen_name=XXXXX

It's common for some people to have a short status + a link to a photo
on facebook or flickr. They aren't full HTML links though just text of the
url. It would be nice to automatically turn them into clickable links in
the DDD ui.

Here's an example feed:

http://api.twitter.com/1/statuses/user_timeline.rss?screen_name=ArgonautCycles


Reply to this email directly or view it on GitHub:
#15

Chris Grindstaff | http://gstaff.org


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-18471370
.

Daniel Hobe [email protected]

@cgrinds
Copy link
Owner

cgrinds commented May 27, 2013

Opps. There now

@hobeone
Copy link
Author

hobeone commented May 27, 2013

LGTM

Works on the few feeds I tested it on.

On Mon, May 27, 2013 at 9:35 AM, Chris Grindstaff
[email protected]:

Opps. There now

?
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-18506366
.

Daniel Hobe [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants