1.0 release #61
Merged
1.0 release #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used the unsafe `[Threads.threadid()]` indexing pattern
Also add one test to make sure call works and shape of return object is correct
Also move `hmc_sample` tests
Moved `construct_x0_mdf` to new file
Think I fixed what ambiguities there were
Removes the old AMR API. This version (1.0) will be the reference for the code version used in the paper.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
===========================================
+ Coverage 69.92% 87.17% +17.25%
===========================================
Files 25 21 -4
Lines 2128 1677 -451
===========================================
- Hits 1488 1462 -26
+ Misses 640 215 -425 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old AMR API (e.g.,
fit_templates_mdf,calculate_coeffs_mdfand so on) which has been superceded (see #56, #58). It should also fix our threading implementations (#60). This version will be the reference for the code version the paper results were produced with.Some smaller changes are listed below
mcmc_sample: argumentnwalkershas been removedTaskLocalValuesis being used for task-local buffersruntests.jland into separate files to be included with SafeTestsets.jl