Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverify all the KMS struct exports and unexport if not needed #2725

Closed
humblec opened this issue Dec 20, 2021 · 2 comments
Closed

Reverify all the KMS struct exports and unexport if not needed #2725

humblec opened this issue Dec 20, 2021 · 2 comments
Labels
cleanup wontfix This will not be worked on

Comments

@humblec
Copy link
Collaborator

humblec commented Dec 20, 2021

Describe the bug

At present all the KMS structs ( SecretKMS,AWSMetadataKMS...etc) where EncryptDEK(), DecryptDEK, ..etc methods are implemented are exposed. However considering all KMS structs reside in the same package (ie kms) we may not need to expose this struct,
This issue track the revalidation and once confirmed all the KMS structs can be unexported.

Ex:

// SecretsKMS is default KMS implementation that means no KMS is in use.
type SecretsKMS struct {
	IntegratedDEK

	passphrase string
}

Additional Ref# #2723 (comment)

Cc @nixpanic

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants