Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break: drop module.GetShare at some point #3951

Open
cristaloleg opened this issue Nov 20, 2024 · 1 comment
Open

break: drop module.GetShare at some point #3951

cristaloleg opened this issue Nov 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request kind:break! Attached to breaking PRs

Comments

@cristaloleg
Copy link
Contributor

cristaloleg commented Nov 20, 2024

Implementation ideas

Based on comment #3891 (comment)

CC: @Wondertan

@cristaloleg cristaloleg added enhancement New feature or request kind:break! Attached to breaking PRs labels Nov 20, 2024
@cristaloleg cristaloleg self-assigned this Nov 20, 2024
@rootulp
Copy link
Contributor

rootulp commented Jan 8, 2025

Notes from call:

  • This isn't just a deprecate + remove. It's a new method.
  • GetSamples accepts different arguments and returns different values.
  • GetSamples returns proofs.
  • Do users use GetShare?
    • Can we get metrics on usage? We have some indirect metrics that we can collect.
    • Can we get signal from Diego or RollKit? Diego already shared which endpoints are used. See doc. GetShare isn't really used.
  • Another method exists: GetRange so GetShare may not be used much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind:break! Attached to breaking PRs
Projects
None yet
Development

No branches or pull requests

2 participants