Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music scene gets index out of bounds #216

Open
cbcerquiaga opened this issue Aug 19, 2019 · 0 comments
Open

Music scene gets index out of bounds #216

cbcerquiaga opened this issue Aug 19, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@cbcerquiaga
Copy link
Owner

When both players are playing and collecting lots of notes, there is an indexOutOfBounds error at line 197 in MusicMinigame.

if notes.size() > 0:
for i in range (0, notes.size() - 1):
var nextNote = notes[i]

I suspect this has to do with how we call
notes.remove(i)
later on in the function, because the function is still looping through all of the notes and if a note is collected (and removed) before one that spawned before it, then the index of that next note would be out of bounds. Not sure if that's what's happening or not though.

@cbcerquiaga cbcerquiaga added the bug Something isn't working label Aug 19, 2019
@cbcerquiaga cbcerquiaga added this to the music minigame milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant