-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honour prefers-reduced-motion by default #228
Comments
I discussed this in #114 already. The tl;dr is that I don't know how this library is used, but I do for a fact know that it is not always purely decorative. All my research on this issue strongly stresses the importance of careful consideration on how to replace motion effects -- not always simply remove them -- on a case-by-case basis. Also, side note, this is a weirdly aggressive stance to take with the developer of a library instead of the developer using a library. Keep in mind, this library does only one single thing: confetti. No one who is using this library is left with the impression that confetti won't happen. No one is being tricked. All developers using this library are doing so on purpose. |
I would not change the default. This is a confetti library after all, the default should be to fire confetti. IMHO this option should not even exist in the library as it is the developer's responsibility to do accessibility right in the context of their project. Interfering with defaults just makes this harder. The worst would be to directly read the user preference from the browser setting because it would entirely bypass the project context and the developer and it would be super hard to debug if you don't know about this setting. What I would like to see however is more fine grained control over the animation and physics. And it would be a good idea to have a section in the docs that explains the importance of accessibility and how to read the browser setting and apply it to animation and physics. |
The README mentions that the
disableForReducedMotion
option is disabled by default.Why?
I don't understand why you would ever override the accessibility preferences a user has set in their own browser.
In my opinion, the
disableForReducedMotion
option should not even exist. If the user has indicated that they prefer reduced motion, simply don't run the script at all.The text was updated successfully, but these errors were encountered: