-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotation on flat confetti #223
Comments
Hey :) thanks for this awesome lib! just to illustrate my use case for this, adapted from the snow example to not stop, but stop on overloaded frame times, using snowflake emoji (the circles didn't stand out enough): don't find 'em sad, and would find them even less sad rotating ❄️ :) |
flat-rotation-proposal.patch it adds a edit: for the snow example, it could also make sense to make the rotation depending on current movement, that may be a more natural feel to configure for several effects. further improvement suggestion: I'd like to have the options available in updateFetti to not have to store them in every fetti. (but on second thought, I suppose that collides with the possible use cases of altering the options every call - maybe an options reference could then improve things marginally? nvm :) |
Hey Catdad,
First off, thank you for this package. It has saved so much time!
I have a small feature request. I'd like to have some 2D confetti using the custom shapes. The
flat: true
option looks perfect, however it turns off the confetti rotation. Like you said in the readme, it looks very sad without any 2D rotation.Would this be something that we could add?
More than happy to raise a PR myself if you'd like, just wanted some guidance on how you'd do it - or if you even think its something worth having in this package (Maybe pure 2D confetti is better of as a separate library).
Let me know what you think!
Cheers
The text was updated successfully, but these errors were encountered: