-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BASiCS_DenoisedCounts requires no further data normalisation? #264
Comments
Just to ask some clarifying questions first: First, when you say you are comparing two samples, are you
Secondly, how are you quantifying mean values? Finally, how are you quantifying the log2FC values? |
I have done single-cell with two cell populations: one DMSO treated and one IdU treated. both samples were analyzed separately with CellRanger, and count matrices were used as input for BASiCS for noise quantification. I'm using different normalization methods to compare mean expression (and noise) between DMSO and IdU. Means are computed based on normalized counts across all cells (rowMeans). log2FC is just dividing the means of IdU by the means of DMSO. In more detail:
|
Hi, |
Thanks for the reproducible example and the code, and sorry for the delay. Will have a look now. I think I understand what's going on but wanted to block some time to be able to write a proper response |
The short story here is that denoised counts is removing the technical |
This is a very strange behavior... I would add a line to the code to normalize the DenoisedCounts matrix, or remove the bold note on the vignette saying that "the output of |
I think it arises from an oversight in the no spikes case that will be fixed in #267 Thanks for raising the issue and documenting it thoroughly, sorry it took so long to get to |
Hello!
I tried implementing
BASiCS_DenoisedCounts
as described in the vignette. I used the chain and the original, raw data (CellRanger output withBASiCS_Filter
applied to it) as input. However, when comparing my two samples, I see a transcriptome-wide drop in mean values of the denoised counts. Here are some plots, comparing the means of all genes between the two samples:Difference in mean values (per gene) before denoising (normalized to sequencing depth):
Difference in mu values after
testDE
(MeanLog2FC
, this seems to be OK):Difference in mean values after denoising using SCTransform:
Difference in mean values after denoising using
BASiCS_DenoisedCounts
(seems to be unnormalized):Did I do something wrong? Or possibly a bug in
BASiCS_DenoisedCounts
?Thanks!
The text was updated successfully, but these errors were encountered: