Make EIA CBECS Archive #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmgosnell
commented
Jan 29, 2025
e-belfer
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Great job handling a really complex dataset. I spot checked 2018, 2012 and 1999 files to make sure nothing was missing.
Approving because all my feedback won't affect the archives, and is mostly for clarity / legibility. (Presuming you'll check SAS files are downloaded as expected before you publish, that's the only thing that was missing when I ran this!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #518.
What problem does this address?
What did you change in this PR?
Testing
How did you make sure this worked? How can a reviewer verify this?
https://zenodo.org/records/14782474
https://sandbox.zenodo.org/records/161000
To-do list
Tasks