Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rpm file which does not have a dependency on /bin/sh #39

Closed
tofay opened this issue Aug 13, 2022 · 1 comment · Fixed by #52
Closed

Support for rpm file which does not have a dependency on /bin/sh #39

tofay opened this issue Aug 13, 2022 · 1 comment · Fixed by #52

Comments

@tofay
Copy link
Contributor

tofay commented Aug 13, 2022

All RPMs generated by cargo-generate-rpm require /bin/sh.

This seems unnecessary, as Rust binaries don't universally require a shell. In my case I'm trying to build distroless-like containers from RPMs generated by cargo-generate-rpm, and this is causing a shell and it's dependencies to be pulled in unnecessarily.

This behaviour comes from by rpm-rs, which appears to not be maintained at present: Richterrettich/rpm-rs#54. I've raised a PR to rpm-rs/rpm#7 - which is a community fork that isn't yet publishing to crates-io.

@cat-in-136 cat-in-136 changed the title All generated rpms have a dependency on /bin/sh Support for rpm file which does not have a dependency on /bin/sh Jan 14, 2023
@cat-in-136
Copy link
Owner

rpm-rs/rpm#7 has been merged to the fork of rpm-rs, which is a maintained-but-not-published-for-a-long-time community fork.

They do not care about backward compatibility. So, it is necessary to do following tasks on switching rpm-rs/rpm:

  • add /bin/sh to dependency automatically, which is usually necessary
  • add functionality to omit /bin/sh in dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants