Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All types are exported, but not all functions #223

Open
Egge21M opened this issue Dec 11, 2024 · 1 comment
Open

All types are exported, but not all functions #223

Egge21M opened this issue Dec 11, 2024 · 1 comment

Comments

@Egge21M
Copy link
Collaborator

Egge21M commented Dec 11, 2024

index.ts exports all of model/types/index.js, but only selected functions are exported. This causes consumers to import functions that are not directly exported like this:

import { sumProofs } from "@cashu/cashu-ts/dist/lib/es5/utils";

We should make sure to only include exported members in the d.ts rollup. This can be done by either explicitly selecting exported types, or using typedoc tags and api-extractor's rollup feature

@gandlafbtc
Copy link
Collaborator

Let's fix this when move to modular exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants